-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add a new nRF52840 dongle "bare" variant #23055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add a new nRF52840 dongle "bare" variant #23055
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 2 projects with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 4a8c8eb6946e50b5a63818770292342a20756a7c more detailssdk-nrf:
mcuboot:
zephyr:
Github labels
List of changed files detected by CI (32)
Outputs:ToolchainVersion: 684b32e022 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
9bd5e42
to
d3c665a
Compare
d3c665a
to
7812628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the build targets be added in the following pages as well?:
- Boards name: https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/app_dev/board_names.html#boards_included_in_sdk-zephyr
- Developing with nRF52 Series - https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/app_dev/device_guides/nrf52/index.html
Also, I think, we would require a change log entry for this change - https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/releases_and_maturity/releases/release-notes-changelog.html#nrf_desktop
7812628
to
c6e12fb
Compare
c6e12fb
to
1e47dc1
Compare
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-23055/nrf/app_dev/board_names.html |
1e47dc1
to
7d4bc62
Compare
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
25909a0
to
5caff6d
Compare
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
5caff6d
to
f89df69
Compare
3d61f24
to
07094df
Compare
07094df
to
bf01c86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but please fix the build error with the link
bf01c86
to
d92a4ff
Compare
d92a4ff
to
259fc32
Compare
bare
variant
bare
variant259fc32
to
cb97093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nRF Desktop changes look good. We could consider adding a few comments (if needed I can add them through a separate PR).
Suggested small improvement to doc modifications too.
applications/nrf_desktop/configuration/nrf52840dongle_nrf52840/pm_static_release_4llpmconn.yml
Show resolved
Hide resolved
Add a documentation, describing nRF52840 dongle bare variant. Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
cb97093
to
bbefec6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a nit.
Remove override for (now promptless) Kconfig. Remove the override to ROM_START_OFFSET, which is already changes if the partition manager is enabled. Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
bbefec6
to
4a8c8eb
Compare
Memory footprint analysis revealed the following potential issuesapplications.nrf_desktop.zdebug[nrf52833dongle/nrf52833]: ROM size increased by 1840[B] in comparison to the main[3908e6c] branch. - link (cc: @nrfconnect/ncs-si-bluebagel) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23055/23) |
Use nRF52840 dongle board variant for applications that overwrite nRF5 SDK bootloader.
Ref: NCSDK-NONE