Skip to content

Add a new nRF52840 dongle "bare" variant #23055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tomchy
Copy link
Contributor

@tomchy tomchy commented Jun 30, 2025

Use nRF52840 dongle board variant for applications that overwrite nRF5 SDK bootloader.

Ref: NCSDK-NONE

@tomchy tomchy requested review from a team as code owners June 30, 2025 15:13
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 30, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 30, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
mcuboot nrfconnect/sdk-mcuboot@c3950c6 nrfconnect/sdk-mcuboot#469 nrfconnect/sdk-mcuboot#469/files
zephyr nrfconnect/sdk-zephyr@f28ed0b (main) nrfconnect/sdk-zephyr#3007 nrfconnect/sdk-zephyr#3007/files

DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 30, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 24

Inputs:

Sources:

sdk-nrf: PR head: 4a8c8eb6946e50b5a63818770292342a20756a7c
mcuboot: PR head: f1d7136aae927e9151c476062fe45b5858499ca4
zephyr: PR head: 3d3d4ab11b66d32e567b61dcca6122ccc723d616

more details

sdk-nrf:

PR head: 4a8c8eb6946e50b5a63818770292342a20756a7c
merge base: 809c81b7e817981210c5494284882dbcbd18f2ee
target head (main): 2ad751afa927550a5c93c10110fc427b7ffe442d
Diff

mcuboot:

PR head: f1d7136aae927e9151c476062fe45b5858499ca4
merge base: c3950c6eea9c4ad0b34436778d479128e5ba3dcb
target head (main): 4eb18b2511d92c295ddab4e36ca8f53e8b2e848f
Diff

zephyr:

PR head: 3d3d4ab11b66d32e567b61dcca6122ccc723d616
merge base: f28ed0b510bd0ba3d9d3d6b719dfd93d481ca52c
target head (main): 81a2b95a7e78217ec0ec0173a0dc9bcc4447ea5e
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (32)
applications
│  ├── nrf_desktop
│  │  ├── board_configuration.rst
│  │  ├── configuration
│  │  │  ├── nrf52840dongle_nrf52840
│  │  │  │  ├── images
│  │  │  │  │  ├── b0
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── prj_3bleconn.conf
│  │  │  │  │  │  ├── prj_4llpmconn.conf
│  │  │  │  │  │  ├── prj_release.conf
│  │  │  │  │  │  │ prj_release_4llpmconn.conf
│  │  │  │  ├── pm_static.yml
│  │  │  │  ├── pm_static_3bleconn.yml
│  │  │  │  ├── pm_static_4llpmconn.yml
│  │  │  │  ├── pm_static_release.yml
│  │  │  │  ├── pm_static_release_4llpmconn.yml
│  │  │  │  ├── prj.conf
│  │  │  │  ├── prj_3bleconn.conf
│  │  │  │  ├── prj_4llpmconn.conf
│  │  │  │  ├── prj_release.conf
│  │  │  │  │ prj_release_4llpmconn.conf
bootloader
│  ├── mcuboot
│  │  ├── boot
│  │  │  ├── zephyr
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf52840dongle_nrf52840_bare.conf
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── board_names.rst
│  │  │  ├── device_guides
│  │  │  │  ├── nrf52
│  │  │  │  │  │ index.rst
│  │  ├── includes
│  │  │  │ sample_board_rows.txt
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf52840dongle
│  │  │  │  ├── Kconfig
│  │  │  │  ├── Kconfig.defconfig
│  │  │  │  ├── board.yml
│  │  │  │  ├── doc
│  │  │  │  │  │ index.rst
│  │  │  │  ├── fstab-stock.dtsi
│  │  │  │  ├── nrf52840dongle_nrf52840.dts
│  │  │  │  ├── nrf52840dongle_nrf52840_bare.dts
│  │  │  │  ├── nrf52840dongle_nrf52840_bare.yaml
│  │  │  │  ├── nrf52840dongle_nrf52840_bare_defconfig
│  │  │  │  │ nrf52840dongle_nrf52840_common.dtsi
│  ├── tests
│  │  ├── drivers
│  │  │  ├── adc
│  │  │  │  ├── adc_api
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf52840dongle_nrf52840_bare.overlay

Outputs:

Toolchain

Version: 684b32e022
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:684b32e022_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 23
  • ✅ Integration tests
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my
    • ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-sdk-audio
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from 9bd5e42 to d3c665a Compare July 1, 2025 08:02
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from d3c665a to 7812628 Compare July 1, 2025 10:53
@tomchy tomchy requested a review from a team as a code owner July 1, 2025 10:53
@tomchy tomchy requested a review from divipillai July 1, 2025 11:05
Copy link
Contributor

@divipillai divipillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from 7812628 to c6e12fb Compare July 3, 2025 13:54
@tomchy tomchy requested review from a team as code owners July 3, 2025 13:54
@tomchy tomchy requested a review from divipillai July 3, 2025 13:54
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 3, 2025
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from c6e12fb to 1e47dc1 Compare July 3, 2025 15:55
Copy link

github-actions bot commented Jul 3, 2025

@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from 1e47dc1 to 7d4bc62 Compare July 4, 2025 10:54
@tomchy tomchy requested a review from greg-fer July 4, 2025 11:28
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from 25909a0 to 5caff6d Compare July 7, 2025 10:08
@tomchy tomchy requested a review from greg-fer July 7, 2025 10:08
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from 5caff6d to f89df69 Compare July 8, 2025 09:45
@tomchy tomchy requested review from greg-fer and FrancescoSer July 8, 2025 09:45
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch 4 times, most recently from 3d61f24 to 07094df Compare July 8, 2025 10:04
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from 07094df to bf01c86 Compare July 8, 2025 10:32
Copy link
Contributor

@FrancescoSer FrancescoSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but please fix the build error with the link

@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from bf01c86 to d92a4ff Compare July 8, 2025 14:11
@tomchy tomchy requested a review from greg-fer July 8, 2025 15:02
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from d92a4ff to 259fc32 Compare July 9, 2025 10:58
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 9, 2025
@tomchy tomchy changed the title applications: Migrate to the new board variant Add a new nRF52840 dongle bare variant Jul 9, 2025
@tomchy tomchy changed the title Add a new nRF52840 dongle bare variant Add a new nRF52840 dongle "bare" variant Jul 9, 2025
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from 259fc32 to cb97093 Compare July 9, 2025 14:01
Copy link
Contributor

@MarekPieta MarekPieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nRF Desktop changes look good. We could consider adding a few comments (if needed I can add them through a separate PR).

Suggested small improvement to doc modifications too.

Add a documentation, describing nRF52840 dongle bare variant.

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from cb97093 to bbefec6 Compare July 14, 2025 08:29
Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a nit.

Remove override for (now promptless) Kconfig.
Remove the override to ROM_START_OFFSET, which is already changes if the
partition manager is enabled.

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
@tomchy tomchy force-pushed the feature/sysbuild/NCSDK-NONE_Introduce_dongle_bare_variant branch from bbefec6 to 4a8c8eb Compare July 14, 2025 08:40
@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug[nrf52833dongle/nrf52833]: ROM size increased by 1840[B] in comparison to the main[3908e6c] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52840dongle/nrf52840]: ROM size increased by 1856[B] in comparison to the main[3908e6c] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_keyboard[nrf52840dk/nrf52840]: ROM size increased by 1872[B] in comparison to the main[3908e6c] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_dongle.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1840[B] in comparison to the main[3908e6c] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1872[B] in comparison to the main[3908e6c] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52840gmouse/nrf52840]: ROM size increased by 1872[B] in comparison to the main[3908e6c] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf54lm20pdk@0.2.0.csp/nrf54lm20a/cpuapp]: ROM size increased by 512[B] in comparison to the main[3908e6c] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23055/23)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM doc-required PR must not be merged without tech writer approval. manifest manifest-mcuboot manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants