Nrfx 7821 run samples subsys ipc ipc service icmsg on more targets #23019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-segl
requested review from
a team,
nordic-piks,
PerMac and
katgiadla
as code owners
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
nordic-piks
approved these changes
Jun 27, 2025
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 271a774dac1d6cdb46903ad7d0bf4c11f8ec7c1b more detailssdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (28)Outputs:ToolchainVersion: 684b32e022 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
nordic-segl
force-pushed
the
NRFX-7821_Run-samples-subsys-ipc-ipc_service-icmsg-on-more-targets
branch
from
8b37fa2 to
0d51959
Compare
miha-nordic
approved these changes
Jun 27, 2025
nordic-segl
force-pushed
the
NRFX-7821_Run-samples-subsys-ipc-ipc_service-icmsg-on-more-targets
branch
2 times, most recently
from
4540abc to
1972095
Compare
|
You can find the documentation preview for this PR here. |
|
There are some failures But generally works in CI: |
nordicjm
reviewed
Jun 30, 2025
|
|
||
| if(NOT CONFIG_BOARD_NRF54LM20PDK_NRF54LM20A_CPUAPP AND | ||
| NOT CONFIG_BOARD_NRF54LV10DK_NRF54LV10A_CPUAPP) | ||
| message(FATAL_ERROR "${BOARD} is not supported for this sample") |
There was a problem hiding this comment.
error if not using sysbuild?
There was a problem hiding this comment.
Isn't SysBuild enabled by default for these targets?
Is CONFIG_BOARD_STM32H747I_DISCO also using SysBuild?
There was a problem hiding this comment.
someone can do west build --no-sysbuild and would get a broken image, we don't care about stm32 builds not working
There was a problem hiding this comment.
As stated above, I don't think there is need to improve this sample because this is a temporary solution.
nordic-segl
force-pushed
the
NRFX-7821_Run-samples-subsys-ipc-ipc_service-icmsg-on-more-targets
branch
2 times, most recently
from
f8382a7 to
7687978
Compare
Copy original sample from Zephyr and enable it on nrf54lv10dk/nrf54lv10a/cpuapp. Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
Include samples: subsys: ipc: ipc_service: icmsg: Enable sample on nRF54H20 nrfconnect/sdk-zephyr#2998 zephyrproject-rtos/zephyr#92287 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
nordic-segl
force-pushed
the
NRFX-7821_Run-samples-subsys-ipc-ipc_service-icmsg-on-more-targets
branch
from
7687978 to
271a774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.