-
Notifications
You must be signed in to change notification settings - Fork 1.3k
treewide: Align networking code with net_mgmt API change #22993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 2 projects with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 1ffdd61db006637d0ecf3d697ad18e04f915e6f9 more detailssdk-nrf:
matter:
zephyr:
Github labels
List of changed files detected by CI (132)
Outputs:ToolchainVersion: 3ae5dc3c63 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR here. |
Please consider also changing this sample, it's about to be merged: |
500009d
to
d210ce9
Compare
f646d5b
to
72760c1
Compare
So we got green CI here, but the PR is blocked until memfault aligns with the latest Zephyr. |
Thanks @rlubos , we'll push out a memfault sdk update asap with the fix! |
@rlubos Memfault SDK |
The net_mgmt event representation changed from 32-bit to 64-bit value, therefore update all net_mgmt callbacks to align with this change. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
72760c1
to
1ffdd61
Compare
@noahp @jtguggedal Thanks! I've rebased the PR and switched to the latest memfault release. |
The net_mgmt event representation changed from 32-bit to 64-bit value, therefore update all net_mgmt callbacks to align with this change.
The purpose of this PR is to catch any leftovers or breakages early, so we don't have to deal with this during the next upmerge. We don't necessarily have to merge it.