Skip to content

treewide: Align networking code with net_mgmt API change #22993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rlubos
Copy link
Contributor

@rlubos rlubos commented Jun 26, 2025

The net_mgmt event representation changed from 32-bit to 64-bit value, therefore update all net_mgmt callbacks to align with this change.

The purpose of this PR is to catch any leftovers or breakages early, so we don't have to deal with this during the next upmerge. We don't necessarily have to merge it.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 26, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 26, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@3ccd607 nrfconnect/sdk-connectedhomeip#622 nrfconnect/sdk-connectedhomeip#622/files
memfault-firmware-sdk memfault/memfault-firmware-sdk@1.26.0 memfault/memfault-firmware-sdk@1.26.1 memfault/memfault-firmware-sdk@1.26.0..1.26.1
zephyr nrfconnect/sdk-zephyr@d7b901d (main) nrfconnect/sdk-zephyr#2990 nrfconnect/sdk-zephyr#2990/files

DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 26, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 1ffdd61db006637d0ecf3d697ad18e04f915e6f9
matter: PR head: 562197cc2f5f39cebb39f8c1b13f4a4121ac2ba5
zephyr: PR head: 7cd7c29528a7bbfbe89c172144c118230d9d88c0

more details

sdk-nrf:

PR head: 1ffdd61db006637d0ecf3d697ad18e04f915e6f9
merge base: e984f3e44d567c8d54c3932ad999cf600aa5ca73
target head (main): 4d3956f22283e35721c29eabb8093e493dce5456
Diff

matter:

PR head: 562197cc2f5f39cebb39f8c1b13f4a4121ac2ba5
merge base: 3ccd6078b9b33af0fa6ddb71e51bb9860f9198a0
target head (master): d56ca73159fd5973d839b14714f0a08b9695d4a8
Diff

zephyr:

PR head: 7cd7c29528a7bbfbe89c172144c118230d9d88c0
merge base: d7b901d0c1951441440037c9fc7e022c065cea96
target head (main): 51f83ce5db20f53c0fd09d3599c5c689623cbf86
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (132)
applications
│  ├── serial_lte_modem
│  │  ├── src
│  │  │  │ slm_ppp.c
lib
│  ├── location
│  │  │ scan_wifi.c
modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── src
│  │  │  │  ├── messaging
│  │  │  │  │  │ ReliableMessageMgr.cpp
│  │  │  │  ├── platform
│  │  │  │  │  ├── nrfconnect
│  │  │  │  │  │  ├── wifi
│  │  │  │  │  │  │  ├── WiFiManager.cpp
│  │  │  │  │  │  │  │ WiFiManager.h
│  ├── wfa-qt
│  │  ├── src
│  │  │  │ wpas_events.c
samples
│  ├── cellular
│  │  ├── modem_shell
│  │  │  ├── src
│  │  │  │  ├── ppp
│  │  │  │  │  │ ppp_ctrl.c
│  │  ├── nrf_cloud_multi_service
│  │  │  ├── src
│  │  │  │  ├── cloud_connection.c
│  │  │  │  │ provisioning_support.c
│  │  ├── nrf_cloud_rest_cell_location
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── nrf_cloud_rest_device_message
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── nrf_cloud_rest_fota
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── nrf_provisioning
│  │  │  ├── src
│  │  │  │  │ main.c
│  ├── debug
│  │  ├── memfault
│  │  │  ├── src
│  │  │  │  │ main.c
│  ├── matter
│  │  ├── light_bulb
│  │  │  ├── src
│  │  │  │  ├── aws_iot_integration
│  │  │  │  │  │ aws_iot_integration.c
│  ├── net
│  │  ├── aws_iot
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── azure_iot_hub
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── coap_client
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── download
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── http_server
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── https_client
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── mqtt
│  │  │  ├── src
│  │  │  │  ├── modules
│  │  │  │  │  ├── network
│  │  │  │  │  │  │ network.c
│  │  ├── udp
│  │  │  ├── src
│  │  │  │  │ main.c
│  ├── wifi
│  │  ├── ble_coex
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── promiscuous
│  │  │  ├── src
│  │  │  │  │ wifi_connection.c
│  │  ├── provisioning
│  │  │  ├── softap
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  ├── raw_tx_packet
│  │  │  ├── src
│  │  │  │  ├── main.c
│  │  │  │  │ wifi_connection.c
│  │  ├── scan
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── shutdown
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── softap
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── sta
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── thread_coex
│  │  │  ├── src
│  │  │  │  ├── ot_coex_functions.c
│  │  │  │  │ ot_coex_functions.h
│  │  ├── twt
│  │  │  ├── src
│  │  │  │  │ main.c
subsys
│  ├── bluetooth
│  │  ├── services
│  │  │  ├── wifi_prov
│  │  │  │  │ wifi_prov_handler.c
│  ├── net
│  │  ├── l2_wifi_if_conn
│  │  │  │ l2_wifi_conn.c
│  │  ├── lib
│  │  │  ├── lwm2m_client_utils
│  │  │  │  ├── location
│  │  │  │  │  │ location_wifi_ap_scanner.c
│  │  │  ├── softap_wifi_provision
│  │  │  │  │ softap_wifi_provision.c
│  │  │  ├── wifi_ready
│  │  │  │  │ wifi_ready.c
tests
│  ├── lib
│  │  ├── location
│  │  │  ├── src
│  │  │  │  │ location_test.c
│  ├── subsys
│  │  ├── net
│  │  │  ├── lib
│  │  │  │  ├── lwm2m_client_utils
│  │  │  │  │  ├── src
│  │  │  │  │  │  ├── stubs.c
│  │  │  │  │  │  ├── stubs.h
│  │  │  │  │  │  │ wifi_ap_scanner.c
west.yml
zephyr
│  ├── doc
│  │  ├── connectivity
│  │  │  ├── networking
│  │  │  │  ├── api
│  │  │  │  │  ├── coap_server.rst
│  │  │  │  │  │ net_mgmt.rst
│  │  ├── releases
│  │  │  ├── migration-guide-4.2.rst
│  │  │  │ release-notes-4.2.rst
│  ├── drivers
│  │  ├── modem
│  │  │  │ modem_cellular.c
│  │  ├── wifi
│  │  │  ├── esp32
│  │  │  │  ├── src
│  │  │  │  │  │ esp_wifi_drv.c
│  ├── include
│  │  ├── zephyr
│  │  │  ├── net
│  │  │  │  ├── coap_mgmt.h
│  │  │  │  ├── conn_mgr_connectivity.h
│  │  │  │  ├── ethernet_mgmt.h
│  │  │  │  ├── ieee802154_mgmt.h
│  │  │  │  ├── net_event.h
│  │  │  │  ├── net_mgmt.h
│  │  │  │  ├── ppp.h
│  │  │  │  ├── socket_net_mgmt.h
│  │  │  │  │ wifi_mgmt.h
│  ├── modules
│  │  ├── hostap
│  │  │  ├── src
│  │  │  │  ├── supp_events.h
│  │  │  │  │ supp_main.c
│  ├── samples
│  │  ├── boards
│  │  │  ├── nxp
│  │  │  │  ├── s32
│  │  │  │  │  ├── netc
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  ├── net
│  │  │  ├── capture
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── cloud
│  │  │  │  ├── mqtt_azure
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  │  ├── tagoio_http_post
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ wifi.c
│  │  │  ├── common
│  │  │  │  │ net_sample_common.c
│  │  │  ├── dhcpv4_client
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── dns_resolve
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── dsa
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── ipv4_autoconf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── lwm2m_client
│  │  │  │  ├── src
│  │  │  │  │  │ lwm2m-client.c
│  │  │  ├── mqtt_sn_publisher
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── secure_mqtt_sensor_actuator
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── sockets
│  │  │  │  ├── coap_download
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  │  ├── coap_server
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ events.c
│  │  │  │  ├── dumb_http_server_mt
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  │  ├── echo_client
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ echo-client.c
│  │  │  │  ├── echo_server
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ echo-server.c
│  │  │  │  ├── packet
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ packet.c
│  │  │  │  ├── txtime
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  ├── wifi
│  │  │  │  ├── apsta_mode
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  ├── subsys
│  │  │  ├── mgmt
│  │  │  │  ├── updatehub
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  ├── subsys
│  │  ├── logging
│  │  │  ├── backends
│  │  │  │  │ log_backend_net.c
│  │  ├── mgmt
│  │  │  ├── mcumgr
│  │  │  │  ├── transport
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ smp_udp.c
│  │  ├── net
│  │  │  ├── conn_mgr
│  │  │  │  ├── conn_mgr_connectivity.c
│  │  │  │  │ events_handler.c
│  │  │  ├── ip
│  │  │  │  ├── ipv4_autoconf.c
│  │  │  │  ├── ipv6_pe.c
│  │  │  │  ├── net_mgmt.c
│  │  │  │  ├── net_stats.c
│  │  │  │  │ pmtu.c
│  │  │  ├── l2
│  │  │  │  ├── ethernet
│  │  │  │  │  ├── arp.c
│  │  │  │  │  ├── ethernet_mgmt.c
│  │  │  │  │  ├── ethernet_stats.c
│  │  │  │  │  ├── lldp
│  │  │  │  │  │  │ lldp.c
│  │  │  │  ├── ieee802154
│  │  │  │  │  ├── ieee802154_mgmt.c
│  │  │  │  │  │ ieee802154_shell.c
│  │  │  │  ├── openthread
│  │  │  │  │  │ openthread.c
│  │  │  │  ├── ppp
│  │  │  │  │  ├── ppp_l2.c
│  │  │  │  │  │ ppp_stats.c
│  │  │  │  ├── virtual
│  │  │  │  │  │ virtual_mgmt.c
│  │  │  │  ├── wifi
│  │  │  │  │  ├── wifi_mgmt.c
│  │  │  │  │  │ wifi_shell.c
│  │  │  ├── lib
│  │  │  │  ├── coap
│  │  │  │  │  ├── coap.c
│  │  │  │  │  │ coap_server.c
│  │  │  │  ├── config
│  │  │  │  │  ├── init.c
│  │  │  │  │  │ init_clock_sntp.c
│  │  │  │  ├── dhcpv4
│  │  │  │  │  │ dhcpv4.c
│  │  │  │  ├── dhcpv6
│  │  │  │  │  │ dhcpv6.c
│  │  │  │  ├── dns
│  │  │  │  │  ├── llmnr_responder.c
│  │  │  │  │  │ mdns_responder.c
│  │  │  │  ├── ptp
│  │  │  │  │  │ port.c
│  │  │  │  ├── shell
│  │  │  │  │  │ events.c
│  │  │  │  ├── sockets
│  │  │  │  │  │ sockets_net_mgmt.c
│  │  ├── shell
│  │  │  ├── backends
│  │  │  │  │ shell_mqtt.c
│  ├── tests
│  │  ├── boards
│  │  │  ├── espressif
│  │  │  │  ├── ethernet
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  │  ├── wifi
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  ├── net
│  │  │  ├── conn_mgr_conn
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── conn_mgr_monitor
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── conn_mgr_nsos
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── dhcpv4
│  │  │  │  ├── client
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  ├── dhcpv6
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── hostname
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── ieee802154
│  │  │  │  ├── l2
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ ieee802154_shell_test.c
│  │  │  ├── igmp
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── lib
│  │  │  │  ├── dns_addremove
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  ├── mgmt
│  │  │  │  ├── src
│  │  │  │  │  │ mgmt.c
│  │  │  ├── mld
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── pmtu
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── socket
│  │  │  │  ├── net_mgmt
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c

Outputs:

Toolchain

Version: 3ae5dc3c63
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3ae5dc3c63_776d264d2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 8
  • ❌ Integration tests
    • ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
    • ❌ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread-main - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_lrcs_positioning - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-wifi
    • ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_mosh
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_positioning
Disabled integration tests
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-sdk-pmic-samples
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

github-actions bot commented Jun 26, 2025

You can find the documentation preview for this PR here.

@pascal-nordic
Copy link
Contributor

Please consider also changing this sample, it's about to be merged:
#22989

@rlubos
Copy link
Contributor Author

rlubos commented Jun 27, 2025

So we got green CI here, but the PR is blocked until memfault aligns with the latest Zephyr.

@jtguggedal
Copy link
Contributor

jtguggedal commented Jun 30, 2025

So we got green CI here, but the PR is blocked until memfault aligns with the latest Zephyr.

@rlubos Updated Memfault SDK was just merged: #23041
Do we need more updates to it?

@rlubos
Copy link
Contributor Author

rlubos commented Jun 30, 2025

So we got green CI here, but the PR is blocked until memfault aligns with the latest Zephyr.

@rlubos Updated Memfault SDK was just merged: #23041 Do we need more updates to it?

Unfortunately yes, 1.26.0 was released just before I've identified the problem and opened a PR with a fix.

@noahp
Copy link
Contributor

noahp commented Jun 30, 2025

Thanks @rlubos , we'll push out a memfault sdk update asap with the fix!

@jtguggedal
Copy link
Contributor

So we got green CI here, but the PR is blocked until memfault aligns with the latest Zephyr.

@rlubos Updated Memfault SDK was just merged: #23041 Do we need more updates to it?

Unfortunately yes, 1.26.0 was released just before I've identified the problem and opened a PR with a fix.

@rlubos Memfault SDK 1.26.1 is released now and should solve the issue: memfault/memfault-firmware-sdk@b99f8c2

The net_mgmt event representation changed from 32-bit to 64-bit value,
therefore update all net_mgmt callbacks to align with this change.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
@rlubos rlubos force-pushed the net/align-with-net-mgmt-changes branch from 72760c1 to 1ffdd61 Compare July 1, 2025 08:02
@rlubos
Copy link
Contributor Author

rlubos commented Jul 1, 2025

@noahp @jtguggedal Thanks! I've rebased the PR and switched to the latest memfault release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-matter manifest-memfault-firmware-sdk manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.