Skip to content

Add support for newer nodejs versions, in the form of '5.x'. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add support for newer nodejs versions, in the form of '5.x'. #21

wants to merge 5 commits into from

Conversation

mtpereira
Copy link

Hello,

Following PRs #19 and #20 , here's a fix for support on newer versions, whilst still maintaining compatibility with older versions' repositories.

Thank you.

# 0.10 or 0.12 or 4.x
nodejs_version: "4.2"
# 0.10 or 0.12 and 4.x, 5.x and onward
nodejs_version: "5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be wise to pin this to 4.x rather than 5.x because those who use Ansible are more likely to be LTS type users and v5.x is only going to last a max of 8 months so we'll be updating this config pretty soon.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

You're absolutely right, will fix it.

Thank you.

On Wed, Nov 18, 2015 at 3:34 AM, Rod Vagg notifications@github.com wrote:

In defaults/main.yml
#21 (comment)
:

@@ -2,5 +2,5 @@

Pin-Priority of NodeSource repository

nodejs_nodesource_pin_priority: 500

-# 0.10 or 0.12 or 4.x
-nodejs_version: "4.2"
+# 0.10 or 0.12 and 4.x, 5.x and onward
+nodejs_version: "5.0"

I think it might be wise to pin this to 4.x rather than 5.x because
those who use Ansible are more likely to be LTS type users and v5.x is only
going to last a max of 8 months so we'll be updating this config pretty
soon.


Reply to this email directly or view it on GitHub
https://github.com/nodesource/ansible-nodejs-role/pull/21/files#r45156477
.

Manuel Tiago Pereira

@rvagg
Copy link
Contributor

rvagg commented Nov 18, 2015

@wolfeidau if you have time could you please review this? It looks good to me aside from my concern re v4.x vs v5.x.

@mtpereira
Copy link
Author

We're now installing LTS (https://nodejs.org/en/blog/release/v4.2.0/) by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants