Skip to content

feat(orama): use new UI components #7971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Conversation

aileenvl
Copy link

@aileenvl aileenvl commented Jul 9, 2025

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@aileenvl aileenvl requested review from a team as code owners July 9, 2025 19:07
Copy link

vercel bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 10, 2025 3:27am

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

I've left some comments, and I am here to help you implement anything you need help with, just ping me :-).

@@ -0,0 +1,185 @@
'use client';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we store Chat and Search in subdirectories?

  • SearchBox/Chat
  • SearchBox/Search

@@ -0,0 +1,185 @@
'use client';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we aren't using SearchOld, can we remove it?

Comment on lines 210 to 217
<Image
src="/static/logos/orama-logo-icon.svg"
alt={t('components.search.poweredBy') + ' Orama'}
width="22"
height="15"
/>
<Image
src="/static/logos/orama-logo.svg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, can we add Orama's logos to ui-components as an Icon?

@avivkeller avivkeller marked this pull request as draft July 9, 2025 20:00
@avivkeller avivkeller changed the title DRAFT: Orama core updates feat(orama): use new UI components Jul 9, 2025
aileenvl and others added 5 commits July 9, 2025 19:24
Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Aileen Villanueva Lecuona <aileenvl@gmail.com>
Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Aileen Villanueva Lecuona <aileenvl@gmail.com>
Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Aileen Villanueva Lecuona <aileenvl@gmail.com>
Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Aileen Villanueva Lecuona <aileenvl@gmail.com>
Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Aileen Villanueva Lecuona <aileenvl@gmail.com>
Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants