Allow shared #5
Open
Allow shared #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@no1msd, any chance this could get merged? If you have no interest in maintaining the project, would you like any help with maintaining it? |
|
Just removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a few things:
BUILD_SHARED_LIBS:BOOL=YESSOVERSIONproperty to the library1.0.2. This is pretty pointless as the version has been released already. The correct thing would be to bump it to1.0.3and do a new release.The bump and source configure prevention I'm not that fussed about. Being able to build shared libraries I would like to be able to do so that I can package up the library correctly and update it through deployment of new packages rather than building in static code to the dependent projects.