Skip to content

Add container registryOverride option #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pditommaso
Copy link
Member

This PR adds an container level config that allows override the registry name then when container name specify a fully qualified repository name,

for example:

process.container = "quay.io/my/container:latest: 

and having in the config

docker.registry = "community.wave.seqera.io" 
docker.registryOverride = true

the final resolved container used by the task execution is going to be

community.wave.seqera.io/my/container:latest

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 82c0000
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/6863dead2ed39900089abca0

@pditommaso
Copy link
Member Author

It could also be explored if it could make sense to have a more compact notation like:

docker.registry "custom.repo.io", override: true

It should be checked if this is going to work when Wave is enabled.

@bentsherman
Copy link
Member

@stevekm would this work for you? See the changes to ContainerHandlerTest to understand how container images would be rewritten

@ewels
Copy link
Member

ewels commented Jun 30, 2025

@bentsherman the additional levels of URI hierarchy that I mentioned is with GitLab, see their docs:

registry.example.com/group/project/image:tag

/project/ represents one extra layer compared to normal - I have a feeling it can also have more layers, with sub-projects.

There may be others as well. Not sure if it's relevant to this PR or not (I think not?), but thought I should flag it.

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants