Skip to content

fix(imip): add context to imip log messages #53751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 1, 2025

Summary

Making the log messages regarding imip processing more useful by including additional context.

Examples of the current state / without this patch

{
  "reqId": "...",
  "level": 2,
  "time": "...",
  "remoteAddr": "",
  "user": "--",
  "app": "no app in context",
  "method": "",
  "url": "--",
  "message": "iMip message event could not be processed because recipient and ORGANIZER must be identical",
  "userAgent": "--",
  "version": "...",
  "data": []
}
{
  "reqId": "...",
  "level": 2,
  "time": "...",
  "remoteAddr": "",
  "user": "--",
  "app": "no app in context",
  "method": "",
  "url": "--",
  "message": "iMip message event dose not contains an organizer",
  "userAgent": "--",
  "version": "...",
  "data": []
}
{
  "reqId": "...",
  "level": 2,
  "time": "...",
  "remoteAddr": "",
  "user": "--",
  "app": "no app in context",
  "method": "",
  "url": "--",
  "message": "iMip message event does not contain a attendee that matches the recipient",
  "userAgent": "--",
  "version": "...",
  "data": []
}

TODO

  • Manual testing

Checklist

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb requested a review from ChristophWurst July 1, 2025 14:00
$logContext = [
'principalUri' => $principalUri,
'sender' => $sender,
'recipient' => $recipient,
Copy link
Contributor Author

@kesselb kesselb Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to know the sender/recipient. But principalUri and event UID (if applicable) might be enough for a start.

Context: The code is processing an imip message. That might be an reply from an external person for a calender invitation or a locall user sending out invitations.

@kesselb kesselb self-assigned this Jul 1, 2025
@kesselb kesselb added this to the Nextcloud 32 milestone Jul 1, 2025
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant