feat(file-versions): #53151 add VersionCreatedEvent event #53746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Borja Domínguez Vázquez <bdominguez@virtualwareco.com>
5 tasks
susnux
reviewed
Jul 1, 2025
| /** | ||
| * Event dispatched after a successful creation of a version | ||
| */ | ||
| class VersionCreatedEvent extends Event { |
There was a problem hiding this comment.
Should it not also include the IVersion? (or VersionEntity)
There was a problem hiding this comment.
True, that also makes more sense to return from the createVersionEntity method.
susnux
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unforked version of #53154
Checklist