Skip to content

fix: handle dav external storage roots with spaces #53729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

icewind1991
Copy link
Member

Allows configuring WebDAV external storage with a space (or other characters that require url encoding) in the "Remote subfolder"

  • Make sure the root we work with isn't urlencoded
  • Encode the general base url

Fixes #52863

@icewind1991 icewind1991 added this to the Nextcloud 32 milestone Jun 30, 2025
@icewind1991 icewind1991 requested a review from a team as a code owner June 30, 2025 15:54
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jun 30, 2025
@icewind1991 icewind1991 removed the request for review from a team June 30, 2025 15:54
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the dav-external-url-encoded-root branch from f52adaa to 6d0119b Compare June 30, 2025 16:01
@icewind1991
Copy link
Member Author

/backport to stable31

@provokateurin
Copy link
Member

@icewind1991 backport to stable30 as well?

@skjnldsv
Copy link
Member

skjnldsv commented Jul 1, 2025

Tests? 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Spaces in remote subfolder of external storage/WebDAV do not work
4 participants