fix: permissions when copying from readonly storage

[rotdrop]

• Resolves: [Bug]: Can't edit/delete files copied from read-only shared folders #51846

Summary

#51846 (comment)

TODO

• Cleanup. Perhaps a bit hacky.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

@rotdrop please use conventional commit messages, e.g.:
fix: permissions when copying from readonly storage

See also https://www.conventionalcommits.org/en/v1.0.0/

[rotdrop]

I wonder if similar permission problems could occur with moveFromStorage, at least in edge cases.

[come-nc]

This is quite mysterious to me, maybe @icewind1991 understands better what this is about?
It’s at least missing comments to make it understandable.

[come-nc]

(did not meant to close, it was a misclick)

[rotdrop]

This is quite mysterious to me, maybe @icewind1991 understands better what this is about? It’s at least missing comments to make it understandable.

Well, but we have the linked issue #51846 with quite a bunch of comments. So in summary:

• when copying files out of read-only storages like read-only shares or read-only external mounts
• ... then the read-only permissions are copied over to the destination
• if you then try to modify the copied files in the destination location then you find them read-only
• this is -- at the very least -- very unexpected: as end-user you of course assume that copying stuff to a location where you have write permissions results in modifiable data
• also: the web-frontend does not provide any means to the end-user to correct this problem