Fix missing collection type in paginated requests #53725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
fix/53674-webdav-paginate-missing-collection-type
branch
from
c4da152 to
55bc091
Compare
salmart-dev
requested review from
icewind1991,
Altahrim and
come-nc
and removed request for
a team
icewind1991
requested changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
json_encodeandjson_decodeare used to store and retrieve entries to/from the cache. This gets rid of any class that is notJsonSerializable. This PR usesserialize/unserializeto avoid this issue.NOTE: other properties could suffer from the same issue in the future. It may be worth making a list of properties that may appear and add them all in this PR to avoid this.
TODO
Checklist