-
Notifications
You must be signed in to change notification settings - Fork 22
[Prototyping] Play around with google drive and AWS testing with github secrets #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoeZiminski
wants to merge
39
commits into
main
Choose a base branch
from
test_gdrive_aws_secrets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile setting up connection
…isting rclone function, moving type hint imports in the conditional block
d26159a
to
1921f6f
Compare
1921f6f
to
086fcd2
Compare
086fcd2
to
34d158e
Compare
Some general thoughts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @cs7-shrey this is PR to prototype a possible approach to testing. This PR will not be merged, it's just here as a rough example.
I set up a NIU google drive and AWS with the credentials as github secrets (I can give you these credentials later you can play with this outside of the CI). The tests connect programmatically to google drive or AWS, setting up the connection and transferring some files. Later we can fill this in to perform some checks that the expected files were transferred.
To have a look at the changes, you can check the diff on the last two commits (one for google drive and one for AWS).
For google drive, I had to change the way that the non-browser connection worked in order to make it programmatic. Now, the user must generate a credentials json through google, and pass the path of this to rclone. A benefit is that it does not require installing rclone on a second machine, but a downside is that it requires a bit more set up on the google end. For now, I'm leaning towards using this method because it can be performed programmatically, and it's roughly equivalent in convenience, and the non-browser case should in any case be infrequently used. Let me know what you think about this, thanks!