Correcting Misleading Protected Modifiers in Presenter class #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inteface Nette\Application\IRouter replaced by Nette\Routing\Router
…e() for persistent parameters. [Closes nette/nette#703][Closes nette/nette#703][Closes nette#69]" (possible BC break) This reverts commit cda17f4. See https://forum.nette.org/cs/35528-stejne-pojmenovany-parametr-akce-presenteru-a-persistentni-odlisne-chovani-v-nette-2-0-oproti-aktualnimu#p221742 BC break: Property must be nullable, ie: #[Persistent] public ?int $foo
…ame>() methods (BC break)
…rs dynamically (BC break) TODO: scanDir must be active
…tion of UrlScript
|
By reviewing the incriminated project, I found that the protected modifiers were not the cause of the false exception being thrown. However, the first and main argument for the change remains, the simplification of unnecessarily complex code. |
dg
force-pushed
the
master
branch
3 times, most recently
from
3463b9a to
ee24f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ApplicationExtension class, the checkPresenter() method enforces that the presenter methods startup(), beforeRender(), afterRender(), and shutdown() must be public and non-static. However, in the base abstract Presenter class within the Nette framework, these methods are defined as protected. While this does not prevent them from being overridden in derived classes, it introduces unnecessary confusion and lacks clear justification.
After upgrading my projects to the latest version of Nette, ApplicationExtension started throwing exceptions such as:
Nette\InvalidStateException: Method Nette\Application\UI\Presenter::checkHttpMethod(): this method must be public non-static.
This issue occurred only in some older projects that had not been updated for a long time, even though all final presenters had correctly set modifiers as public, while the majority of my updated projects remained unaffected. I could not determine why certain projects triggered the exception while others did not. However, after manually refactoring the Presenter class inside /vendor/ and changing the visibility of the mentioned methods from protected to public, the issue was completely resolved—without any loss of normal presenter functionality.
Proposed Change
I propose modifying the affected methods in the nette/application package by changing their visibility from protected to public, for two key reasons:
a) eliminating unnecessary confusion - the protected modifier in this context serves no meaningful purpose and only introduces ambiguity.
b) preventing unnecessary exceptions - under specific conditions, even syntactically correct final presenters can unexpectedly trigger errors, which this change would effectively prevent.
I opened this theme for public discussion on forum nette