Skip to content

feat(sign): add generics to sign and sign async methods #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahmedwael216
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

the sign ans sign async when provided with an object don't accept generics, while the decode does,

What is the new behavior?

make the sign and sign async accept generics when provided an object, this increases type safety and prevents DX

Does this PR introduce a breaking change?

  • Yes
  • No

@ahmedwael216 ahmedwael216 changed the title feat(sign): add generics to sign ans sign async methods feat(sign): add generics to sign and sign async methods May 13, 2025
@ahmedwael216 ahmedwael216 force-pushed the add-generics-to-sign branch from 8e9f68d to bf52b54 Compare May 13, 2025 08:17
@Ibrahim-Soltan
Copy link

Finally this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants