DOCSP-46497 & DOCSP-46233: Add historical and line item billing examples to Go SDK project #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbullinger
changed the title
dacharyc
requested changes
Jul 3, 2025
There was a problem hiding this comment.
This is a lot of work, and I'm very impressed with the thoroughness and handling you've done here! Only a couple of blocking comments related to the generated output project - it won't run as-is because there are some bits still hanging out from before you did the refactor. The rest of the comments are just Qs, kudos, and non-blocking nits.
We should probably also update the INTERNAL_README.md with the updated directory structure, similar to what you did in the README.md.
usage-examples/go/atlas-sdk-go/internal/billing/sku_classifier_test.go
Outdated
Show resolved
Hide resolved
| // NOTE: You can define a default global directory for all generated files by setting the ATLAS_DOWNLOADS_DIR environment variable. | ||
| func GenerateOutputPath(dir, prefix, extension string) (string, error) { | ||
| // If default download directory is set in .env, prepend it to the provided dir | ||
| defaultDir := os.Getenv("ATLAS_DOWNLOADS_DIR") |
There was a problem hiding this comment.
Nice - very thoughtful approach!
generated-usage-examples/go/atlas-sdk-go/project-copy/internal/billing/linked_billing.go
Show resolved
Hide resolved
generated-usage-examples/go/atlas-sdk-go/project-copy/internal/fileutils/io.go
Outdated
Show resolved
Hide resolved
usage-examples/go/atlas-sdk-go/examples/monitoring/logs/main.go
Outdated
Show resolved
Hide resolved
dacharyc
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add examples, functions, and related tests for the following billing functionality:
Project changes:
cmd>examplesexamples/monitoringLinked Jira tickets:
Related Tasks
docs repo tasks
artifact repo tasks
README.mdCHANGELOG.md