-
Notifications
You must be signed in to change notification settings - Fork 74
handle data streaming for new responses API #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/mongodb-chatbot-server/src/routes/responses/createResponse.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-chatbot-server/src/routes/responses/createResponse.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely looks directionally correct. left a few notes.
packages/mongodb-chatbot-server/src/routes/responses/createResponse.test.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-chatbot-server/src/routes/responses/createResponse.test.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-chatbot-server/src/routes/responses/createResponse.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
back 2 u. think getting very close. this looks great. very exciting. happy to chat further on any of the points in a call
packages/mongodb-chatbot-server/src/routes/responses/createResponse.test.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-chatbot-server/src/routes/responses/createResponse.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-chatbot-server/src/routes/responses/createResponse.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-chatbot-server/src/routes/responses/responsesRouter.test.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-chatbot-server/src/routes/responses/responsesRouter.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % few tiny nits and 1 request for tests. awesome work here! we're getting close.
with this, you've pretty much finished the hard part on the server, and now get to do the fun (and also probably somewhat hard) part integrating the AI
Jira: https://jira.mongodb.org/browse/EAI-1154
Changes
Notes