[feature branch] Search Content API #786
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create MongoDbSearchResultsStore, add limit to DefaultFindContent and add test for limit * Implement saveSearchResult, create MongoDbSearchResultsStore.test.ts * lint, format * Check entire returned document in MongoDbSearchResultsStore.test.ts * Create ResultChunk type and zod check * Correct usage of limit in makeDefaultFindContent * PR feedback: cast badSearchResultRecord as any * Use unknown instead of any for ResultChunk additional metadata * PR feedback: Combine describe blocks in MongoDbSearchResultsStore.test.ts, remove zod checks where unnecessary in MongoDbSearchResultsStore * Combine describes
* Create MongoDbSearchResultsStore, add limit to DefaultFindContent and add test for limit * Implement saveSearchResult, create MongoDbSearchResultsStore.test.ts * lint, format * Check entire returned document in MongoDbSearchResultsStore.test.ts * Create ResultChunk type and zod check * Correct usage of limit in makeDefaultFindContent * PR feedback: cast badSearchResultRecord as any * Starting structure of searchContent * Use unknown instead of any for ResultChunk additional metadata * Add searchContent test file, broaden QueryFilter & MongoDbAtlasVectorSearchFilter types * Work on clarity of comments in contentRouter * PR feedback: Combine describe blocks in MongoDbSearchResultsStore.test.ts, remove zod checks where unnecessary in MongoDbSearchResultsStore * Use generics on middleware: requireRequestOrigin, requireValidIpAddress * Structure out contentRouter test file * Combine describes * Clean * makeFindContentWithMongoDbMetadata * config.test.ts * Clean * PR feedback * Correct types * Correct test * Fix test return type * lint * Revert move of classifyMongoDbProgrammingLanguageAndProduct, jest needs function outside of file to mock * Remove unnecessary tests and comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-
Changes
Notes