Skip to content

BUGFIX - do not replace values in edit view #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrname
Copy link

@mrname mrname commented Jun 12, 2018

When editing a pre-existing advanced filter object, the javascript is overwriting pre-existing values with a blank select 2 box like so:

select2_bug

The fix implemented here modifies the behavior like so:

select2_fixed

Note that I am not much of a JS dev, so not sure this is the best way to handle the issue.

@coveralls
Copy link

coveralls commented Jun 12, 2018

Coverage Status

Coverage remained the same at 96.06% when pulling f1c1f5e on mrname:detail_view_select2_fix into c88bafc on modlinltd:develop.

@mrname
Copy link
Author

mrname commented Jun 28, 2018

Actually, it looks like this PR handles the issue in a better way:

#31

However, it has not made movement in about 2 years. Is there something that still needs to be done there that I could assist with?

@asfaltboy
Copy link
Member

Thanks @mrname , would you mind testing PR #31 out and giving you feedback on it there?

@mrname
Copy link
Author

mrname commented Jun 28, 2018

Sounds good @asfaltboy I will go ahead and close this PR in the meantime as well.

@mrname mrname closed this Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants