Skip to content
This repository was archived by the owner on Jun 23, 2022. It is now read-only.

Added SQLite support #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added SQLite support #2

wants to merge 4 commits into from

Conversation

YoSoyVillaa
Copy link

No description provided.

Copy link
Owner

@mnewt00 mnewt00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going of from what I can see in the code, it isn't bad although some changes could be made. I don't see much of a point of using SQLite rather than Vulcan's own flat-file storage logs.

I'll also need to test this all in-game later, however, VDB 1.0.4 likely wouldn't be released for a while as I don't have much motivation.

@mnewt00 mnewt00 added the enhancement New feature or request label Apr 17, 2022
@mnewt00 mnewt00 added this to the 1.0.4 milestone Apr 17, 2022
@YoSoyVillaa
Copy link
Author

Cause of my MySQL configuration, I don't know why but it drops VulcanDatatabase's connection (only to this plugin), and flat files of Vulcan have a horrible performance, so I made it compatible with SQLite and make the PR if you want to add it in the future, and therefore save you work.

I think this could work, I have to make connection not final to modify it, because if I try to put connection = null on catch clause, the IDE forces me to use a temp variable (connection1), I think you understood me, didn't you?

On the other side, I have tested it on my network and it works correctly, but I think anyway to will test it :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants