add device id to feature flag context by default #867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new
device_id
field (mapped toanonymousId
) in the Mixpanel Feature Flag system. The changes ensure thatdevice_id
is properly handled in both the main application logic and the associated tests.Feature enhancements:
src/main/java/com/mixpanel/android/mpmetrics/FeatureFlagDelegate.java
: Added a new methodgetAnonymousId()
to theFeatureFlagDelegate
interface to retrieve thedevice_id
.src/main/java/com/mixpanel/android/mpmetrics/FeatureFlagManager.java
: Updated_performFetchRequest()
to includedevice_id
in the request context JSON. [1] [2]Test updates:
src/androidTest/java/com/mixpanel/android/mpmetrics/FeatureFlagManagerTest.java
:MockFeatureFlagDelegate
to supportanonymousIdToReturn
. [1] [2]testRequestBodyConstruction_performFetchRequest
,testRequestBodyConstruction_withNullContext
,testRequestBodyConstruction_withEmptyDistinctId
,testFlagsConfigContextUsage_emptyContext
) to verify the inclusion and correctness of thedevice_id
field in the request context. [1] [2] [3] [4] [5]