Fix System.exit() security vulnerability in ExceptionHandler

[Copilot]

This PR addresses a security vulnerability identified during a security review where the use of System.exit(10) in ExceptionHandler.java was flagged as inappropriate coding practice according to CWE-382: J2EE Bad Practices: Use of System.exit().

Changes Made

• Removed System.exit(10) call from the killProcessAndExit() method to eliminate the security vulnerability
• Added proper interrupt handling by calling Thread.currentThread().interrupt() to restore the interrupted status when a thread is interrupted during sleep
• Added documentation comment to clarify the graceful exit approach

Before

private void killProcessAndExit() {
    try {
        Thread.sleep(SLEEP_TIMEOUT_MS);
    } catch (InterruptedException e1) {
        e1.printStackTrace();
    }
    android.os.Process.killProcess(android.os.Process.myPid());
    System.exit(10);  // ❌ Security vulnerability
}

After

private void killProcessAndExit() {
    try {
        Thread.sleep(SLEEP_TIMEOUT_MS);
    } catch (InterruptedException e1) {
        e1.printStackTrace();
        Thread.currentThread().interrupt(); // ✅ Restore interrupted status
    }
    // Finish all activities and exit the application gracefully
    android.os.Process.killProcess(android.os.Process.myPid());
}

Impact

• Security: Eliminates CWE-382 violation by removing inappropriate System.exit() usage
• Functionality: No behavioral change since android.os.Process.killProcess() already terminates the process effectively
• Best Practices: Follows Java threading best practices by properly handling thread interruption
• Android Compliance: Uses Android-appropriate process termination methods

The System.exit(10) call was redundant since android.os.Process.killProcess(android.os.Process.myPid()) already terminates the process. Removing it addresses the security concern without any functional impact.

Fixes #856.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• dl.google.com
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx1536M -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.11.1-bin/bpt9gzteqjrbo1mjrsomdt32c/gradle-8.11.1/lib/gradle-daemon-main-8.11.1.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.11.1-bin/bpt9gzteqjrbo1mjrsomdt32c/gradle-8.11.1/lib/agents/gradle-instrumentation-agent-8.11.1.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.11.1 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull Request Overview

This PR addresses a security vulnerability by removing an inappropriate System.exit(10) call from ExceptionHandler and improving thread interruption handling.

• Removed System.exit(10) to prevent abrupt termination and improve security
• Added Thread.currentThread().interrupt() in the catch block to restore the interrupted status
• Added a clarifying comment regarding a graceful exit approach

[Copilot]

[nitpick] Consider replacing e1.printStackTrace() with a proper logging mechanism for production environments to improve maintainability and log management.

Suggested change

	e1.printStackTrace();
	Log.e("ExceptionHandler", "Interrupted while sleeping", e1);