Skip to content

chore(codegen): move action update into the recorder app #36523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(codegen): move action update into the recorder app #36523

wants to merge 1 commit into from
+282 −205

Conversation

pavelfeldman
Copy link
Member

No description provided.

yury-s
yury-s approved these changes Jul 1, 2025
View reviewed changes
packages/playwright-core/src/server/browserContext.ts

// When paused, show inspector.
if (this._debugger.isPaused())
Recorder.showInspectorNoReply(this, RecorderApp.factory(this));
await RecorderApp.showInspectorNoReply(this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await RecorderApp.showInspectorNoReply(this);
RecorderApp.showInspectorNoReply(this);

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Test results for "tests 1"

97 failed
❌ [chromium-library] › library/inspector/pause.spec.ts:108:5 › pause › should show source @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:121:5 › pause › should pause on next pause @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:137:5 › pause › should step @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:155:5 › pause › should step with keyboard shortcut @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:233:5 › pause › should populate log @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:254:5 › pause › should hide internal calls @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:278:5 › pause › should show expect.toHaveText @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:301:5 › pause › should highlight waitForEvent @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:319:5 › pause › should populate log with waitForEvent @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:344:5 › pause › should populate log with error @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:364:5 › pause › should populate log with error in waitForEvent @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:390:5 › pause › should pause on page close @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:403:5 › pause › should pause on context close @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:469:5 › pause › should not prevent key events @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:530:5 › pause › should record from debugger @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:108:5 › pause › should show source @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:121:5 › pause › should pause on next pause @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:137:5 › pause › should step @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:155:5 › pause › should step with keyboard shortcut @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:233:5 › pause › should populate log @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:254:5 › pause › should hide internal calls @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:278:5 › pause › should show expect.toHaveText @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:301:5 › pause › should highlight waitForEvent @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:319:5 › pause › should populate log with waitForEvent @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:344:5 › pause › should populate log with error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:364:5 › pause › should populate log with error in waitForEvent @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:390:5 › pause › should pause on page close @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:403:5 › pause › should pause on context close @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:469:5 › pause › should not prevent key events @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:530:5 › pause › should record from debugger @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:108:5 › pause › should show source @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:121:5 › pause › should pause on next pause @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:137:5 › pause › should step @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:155:5 › pause › should step with keyboard shortcut @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:233:5 › pause › should populate log @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:254:5 › pause › should hide internal calls @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:278:5 › pause › should show expect.toHaveText @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:301:5 › pause › should highlight waitForEvent @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:319:5 › pause › should populate log with waitForEvent @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:344:5 › pause › should populate log with error @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:364:5 › pause › should populate log with error in waitForEvent @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:390:5 › pause › should pause on page close @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:403:5 › pause › should pause on context close @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:469:5 › pause › should not prevent key events @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:530:5 › pause › should record from debugger @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/inspector/pause.spec.ts:108:5 › pause › should show source @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:121:5 › pause › should pause on next pause @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:137:5 › pause › should step @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:155:5 › pause › should step with keyboard shortcut @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:233:5 › pause › should populate log @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:254:5 › pause › should hide internal calls @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:278:5 › pause › should show expect.toHaveText @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:301:5 › pause › should highlight waitForEvent @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:319:5 › pause › should populate log with waitForEvent @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:344:5 › pause › should populate log with error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:364:5 › pause › should populate log with error in waitForEvent @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:390:5 › pause › should pause on page close @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:403:5 › pause › should pause on context close @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:469:5 › pause › should not prevent key events @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:530:5 › pause › should record from debugger @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/inspector/pause.spec.ts:108:5 › pause › should show source @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:121:5 › pause › should pause on next pause @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:137:5 › pause › should step @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:155:5 › pause › should step with keyboard shortcut @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:233:5 › pause › should populate log @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:254:5 › pause › should hide internal calls @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:278:5 › pause › should show expect.toHaveText @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:301:5 › pause › should highlight waitForEvent @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:319:5 › pause › should populate log with waitForEvent @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:344:5 › pause › should populate log with error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:364:5 › pause › should populate log with error in waitForEvent @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:390:5 › pause › should pause on page close @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:403:5 › pause › should pause on context close @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:469:5 › pause › should not prevent key events @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/inspector/pause.spec.ts:530:5 › pause › should record from debugger @ubuntu-22.04-chromium-tip-of-tree
❌ [webkit-library] › library/inspector/pause.spec.ts:108:5 › pause › should show source @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:121:5 › pause › should pause on next pause @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:137:5 › pause › should step @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:155:5 › pause › should step with keyboard shortcut @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:233:5 › pause › should populate log @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:254:5 › pause › should hide internal calls @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:278:5 › pause › should show expect.toHaveText @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:301:5 › pause › should highlight waitForEvent @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:319:5 › pause › should populate log with waitForEvent @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:344:5 › pause › should populate log with error @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:364:5 › pause › should populate log with error in waitForEvent @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:390:5 › pause › should pause on page close @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:403:5 › pause › should pause on context close @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:469:5 › pause › should not prevent key events @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/pause.spec.ts:530:5 › pause › should record from debugger @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/inspector/title.spec.ts:35:5 › should update primary page URL when original primary closes @webkit-ubuntu-22.04-node18

4 flaky ⚠️ [chromium-library] › library/chromium/tracing.spec.ts:49:3 › should run with custom categories if provided @chromium-ubuntu-22.04-node18
⚠️ [chromium-library] › library/popup.spec.ts:258:3 › should not throw when click closes popup @chromium-ubuntu-22.04-node24
⚠️ [playwright-test] › ui-mode-trace.spec.ts:587:5 › should indicate current test status @macos-latest-node18-1
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18

41539 passed, 788 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelfeldman @yury-s