fix: various WebSocketRoute issues #36517
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not allow two clients to route simultaneously. - Cleanup after dispatcher disconnects. - Ensure that routing works in context reuse scenarios. - Test context reuse both in the launched browser with a single connection, and in a connected browser with different connections.
Test results for "tests 1"1 failed 5 flaky47126 passed, 979 skipped Merge workflow run. |
yury-s
reviewed
Jul 1, 2025
| } | ||
| ++data.counter; | ||
|
|
||
| return await target.addInitScript(progress, ` |
There was a problem hiding this comment.
Why do we add the same module again when the counter > 1?
| @@ -319,7 +320,7 @@ export class BrowserContextDispatcher extends Dispatcher<BrowserContext, channel | |||
| async setWebSocketInterceptionPatterns(params: channels.PageSetWebSocketInterceptionPatternsParams, progress: Progress): Promise<void> { | |||
| this._webSocketInterceptionPatterns = params.patterns; | |||
| if (params.patterns.length) | |||
| await WebSocketRouteDispatcher.installIfNeeded(progress, this.connection, this._context); | |||
| this._routeWebSocketInitScripts.push(await WebSocketRouteDispatcher.install(progress, this.connection, this._context)); | |||
There was a problem hiding this comment.
how any why can we have more than one init script here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36480. References #35987.