Skip to content

chore: abort pending operations upon disconnect #36496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jun 30, 2025

This involves a few changes:

  • protocol cleanup as every channel is now "progress: true";
  • keeping ProgressController instances of ongoing operations inside the dispatcher;
  • replacing Dispatcher._openScope with aborting progress controllers;
  • instead of issuing stopPendingOperations() when disconnecting from a reused context, we call an explicit disconnectFromReusedContext() method;
  • various small cleanups.

References #35987.

This comment has been minimized.

@dgozman dgozman force-pushed the chore-cleanup-progress-more branch from 908fee6 to 64b6b88 Compare June 30, 2025 14:08

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter-html.spec.ts:2924:5 › merged › execSync doesnt produce a second stdout attachment @macos-latest-node18-2

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1087:7 › cli codegen record › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node18-1

47010 passed, 983 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman requested a review from pavelfeldman June 30, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants