docs(component testing): add Svelte hooks example #36491
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the missing Svelte component testing hooks example to the documentation, showing how to use beforeMount and afterMount hooks with hooksConfig for setting up component context. Fixes microsoft#31367
|
@microsoft-github-policy-service agree |
sand4rt
reviewed
Jun 30, 2025
| import type { HooksConfig } from '../playwright'; | ||
| import Context from './Context.svelte'; | ||
|
|
||
| test('context', async ({ mount }) => { |
There was a problem hiding this comment.
This text becomes inaccurate when an example other than a router example is used:
"An example of configuring a router is provided below"
I would suggest replacing all examples with a "dependency injection" example rather than a routing example to ensure consistency. This approach essentially reflects what libraries like routers use under the hood (with the exception of Svelte).
For reference, see:
- for vue see: https://vuejs.org/guide/components/provide-inject.html#provide-inject
- for svelte see: https://svelte.dev/docs/svelte/context
- for react see: https://react.dev/reference/react/useContext
Let’s wait for the Playwright team to confirm they’re okay with this.
There was a problem hiding this comment.
Sure, let's wait for the team to verify. Thanks for the pointer anyway.
There was a problem hiding this comment.
I'd rather not touch the existing react example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the missing Svelte component testing hooks example to the documentation, showing how to use beforeMount and afterMount hooks with hooksConfig for setting up component context.
Fixes #31367