feat(playwright-html-report): Added snippet parameter to playwright config #36464
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Skn0tt
reviewed
Jun 27, 2025
tests/library/snippet.spec.ts
Outdated
| // 3. Open the HTML report and confirm that the code snippet is NOT present for the failure. | ||
| // 4. Change snippets: true and confirm the snippet IS present. | ||
|
|
||
| test('should fail and allow visual check of HTML report snippet', async () => { |
There was a problem hiding this comment.
Take a look at reporter-html.spec.ts and add a test into that file.
tests/library/playwright.config.ts
Outdated
| @@ -48,7 +48,7 @@ const reporters = () => { | |||
| ['json', { outputFile: path.join(outputDir, 'report.json') }], | |||
| ['blob', { fileName: `${process.env.PWTEST_BOT_NAME}.zip` }], | |||
| ] : [ | |||
| ['html', { open: 'on-failure', title: 'Playwright Library Tests' }] | |||
| ['html', { open: 'on-failure', title: 'Playwright Library Tests', snippets: true }] | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Just want to let you know that during development, I noticed that single test runs (npm run ctest -- specific-test.spec.ts) don't always pass reporter options through properly, but when running full test, everything seems to run correctly. So it looks like this doesn't affect the feature's functionality in real usage. |
This comment has been minimized.
This comment has been minimized.
Skn0tt
approved these changes
Jun 30, 2025
Skn0tt
reviewed
Jun 30, 2025
Signed-off-by: Simon Knott <info@simonknott.de>
This comment has been minimized.
This comment has been minimized.
|
@agamjots05 Do you plan to follow up with reverting package.json and package-lock.json changes? |
done 👍 |
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 failed 10 flaky47087 passed, 980 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34052
Before
After (Disabling Snippets through playwright config)
New Playwright Config Change:
HTML - Report Disabling Snippets
