Skip to content

feat(webkit): allow running WebKit via WSL on Windows #36358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(webkit): allow running WebKit via WSL on Windows #36358

wants to merge 4 commits into from
+526 −464

Conversation

mxschmitt
Copy link
Member

No description provided.

@mxschmitt mxschmitt force-pushed the webkit-via-wsl-experiment branch from 10a64dd to 34667d2 Compare June 19, 2025 12:30
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

2 fatal errors, not part of any test
18 failed
❌ [webkit-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @webkit-wsl-headed
❌ [webkit-library] › library/beforeunload.spec.ts:30:3 › should close browsercontext with beforeunload page @webkit-wsl-headed
❌ [webkit-library] › library/beforeunload.spec.ts:38:3 › should be able to navigate away from page with beforeunload @webkit-wsl-headed
❌ [webkit-library] › library/beforeunload.spec.ts:46:3 › should close page with beforeunload listener @webkit-wsl-headed
❌ [webkit-library] › library/beforeunload.spec.ts:55:3 › should run beforeunload if asked for @smoke @webkit-wsl-headed
❌ [webkit-library] › library/beforeunload.spec.ts:79:3 › should access page after beforeunload @webkit-wsl-headed
❌ [webkit-library] › library/beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload @webkit-wsl-headed
❌ [webkit-library] › library/beforeunload.spec.ts:107:3 › should not stall on click when dismissing beforeunload @webkit-wsl-headed
❌ [webkit-library] › library/browser.spec.ts:20:5 › should return browserType @webkit-wsl-headed
❌ [webkit-library] › library/browser.spec.ts:24:5 › should create new page @smoke @webkit-wsl-headed
❌ [webkit-library] › library/browser.spec.ts:38:5 › should throw upon second create new page @webkit-wsl-headed
❌ [webkit-library] › library/browser.spec.ts:46:5 › version should work @webkit-wsl-headed
❌ [webkit-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @webkit-wsl-headed
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke @webkit-wsl-headed
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:32:3 › should work with expires=-1 @webkit-wsl-headed
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:50:3 › should add cookies with empty value @webkit-wsl-headed
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:68:3 › should set cookies with SameSite attribute and no secure attribute @webkit-wsl-headed
❌ [webkit-library] › library/browsercontext-add-init-script.spec.ts:20:3 › should work with browser context scripts @smoke @webkit-wsl-headed

0 passed, 4091 did not run
✔️✔️✔️

Merge workflow run.

agg23
agg23 reviewed Jun 19, 2025
View reviewed changes
Copy link
Contributor

@agg23 agg23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clean. I like it.

packages/playwright-core/bin/webkit-wsl-pipe-wrapper.mjs
socket.on('error', reject);
});

const [executable, ...args] = process.argv.slice(2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this is run by us, this should have proper error handling.

packages/playwright-core/src/server/browserType.ts Outdated
env: {
...this.amendEnvironment(env, userDataDir, executable, browserArguments, options.channel),
"WSLENV": "SOCKET_ADDRESS",
'SOCKET_ADDRESS': (transportServer?.address() as any)?.port?.toString() ?? '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is our goal here if we don't have a transport?

@mxschmitt mxschmitt force-pushed the webkit-via-wsl-experiment branch 8 times, most recently from bae0c10 to 18c9ba8 Compare June 30, 2025 11:17
This was referenced Jun 30, 2025
Merged
Merged
@mxschmitt mxschmitt force-pushed the webkit-via-wsl-experiment branch from ba3bd42 to 48251d4 Compare June 30, 2025 15:40
@mxschmitt mxschmitt mentioned this pull request Jul 1, 2025
Merged
@mxschmitt mxschmitt force-pushed the webkit-via-wsl-experiment branch from 48251d4 to 62bd7f5 Compare July 1, 2025 09:00
mxschmitt
mxschmitt commented Jul 1, 2025
View reviewed changes
packages/playwright-core/src/server/webkit/webkit.ts Outdated
override amendEnvironment(env: Env, userDataDir: string, executable: string, browserArguments: string[], channel?: string): Env {
return {
...env,
// CURL_COOKIE_JAR_PATH: path.join(channel === 'webkit-wsl' ? translatePathToWSL(userDataDir) : userDataDir, 'cookiejar.db'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if condition.

@mxschmitt mxschmitt mentioned this pull request Jul 1, 2025
Merged
@mxschmitt mxschmitt force-pushed the webkit-via-wsl-experiment branch from 62bd7f5 to e8c3971 Compare July 2, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agg23 agg23 agg23 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @agg23