Skip to content

refactor: optimize Dockerfile for web and space applications by refin… #7223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025

Conversation

pratapalakshmi
Copy link
Contributor

@pratapalakshmi pratapalakshmi commented Jun 17, 2025

This reduces:

The existing web-enterprise from 2.57GB to 517MB
The existing space-enterprise from 1.13GB to 406MB

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated Dockerfile configurations to copy only the necessary static assets for deployment, resulting in a leaner final image and improved build efficiency. The public assets are now placed directly in their target directories. No changes to user-facing features or functionality.

Copy link
Contributor

coderabbitai bot commented Jun 17, 2025

Walkthrough

The Dockerfiles for both the space and web components were updated to refine how build artifacts are copied in the final image. Instead of copying the entire .next directory, only the .next/static subdirectory is now included, while the public directory copy remains unchanged for the space component.

Changes

File(s) Summary of Changes
space/Dockerfile.space Modified copy commands in the runner stage: copied .next/standalone to root, only .next/static to ./space/.next/static, and public to ./space/public.
web/Dockerfile.web Modified copy command in the runner stage: copied only .next/static to ./web/.next/static instead of full .next.

Poem

In Dockerfiles, we trim and prune,
Only static now, beneath the moon.
Public files find a brand new place,
Leaner images, a tidier space.
With every hop and every run,
Our containers shine—job well done!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fd448d and 59a682f.

📒 Files selected for processing (1)
  • space/Dockerfile.space (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • space/Dockerfile.space
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (javascript)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0983e5f and ee1d618.

📒 Files selected for processing (2)
  • space/Dockerfile.space (1 hunks)
  • web/Dockerfile.web (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
web/Dockerfile.web (1)

106-106: Add EXPOSE 3000 for consistency
Including EXPOSE 3000 aligns the Web Dockerfile with the Space variant and the Next.js default port.

space/Dockerfile.space (1)

59-61: Approve targeted asset copying
Great optimization—only .next/static and public are included in the runner, reducing image size. Ensure the standalone build doesn’t require other .next subdirectories at runtime.

Please verify by launching a container and confirming that all routes and static assets serve correctly without the full .next directory.

@twtaylor
Copy link
Collaborator

@lifeiscontent this might be of interest to you

@sriramveeraghanta sriramveeraghanta merged commit 549a000 into makeplane:preview Jul 2, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants