-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[WEB-4281] chore: error code on project updation endpoint #7218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: preview
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Pull Request Linked with Plane Work Items Comment Automatically Generated by Plane |
1 similar comment
Pull Request Linked with Plane Work Items Comment Automatically Generated by Plane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apiserver/plane/app/views/project/base.py
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apiserver/plane/app/views/project/base.py (1)
440-445
:serializers.ValidationError
branch is probably unreachable
serializer.is_valid()
returnsFalse
and puts details inserializer.errors
; it does not raiseValidationError
.
ValidationError
is only raised fromserializer.save()
whenupdate()
/create()
explicitly do so – yourProjectSerializer
doesn’t appear to. In practice a duplicate identifier on partial update will fall into theIntegrityError
path above, giving the wrong"name"
payload.Re-verify this branch ever triggers; if not, remove it and rely on the consolidated duplicate-key handler suggested earlier.
Description
This PR will add an error code on project updation.
Type of Change
References
Related PR
Summary by CodeRabbit