Skip to content

chore: make min and max props of animated-circular-progress-bar.tsx optional #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stabldev
Copy link

Make min and max properties of animated-circular-progress-bar.tsx component optional, as default values are already defined for them.

Copy link

vercel bot commented Jun 10, 2025

@moonlitgrace is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@itsarghyadas
Copy link
Collaborator

min and max can be optional, but value shouldn't be - we prefer users to provide a defined value rather than relying on a default 0

Could you update the PR accordingly so I can merge it @stabldev ?

@itsarghyadas itsarghyadas added the enhancement New feature or request label Jun 27, 2025
@stabldev
Copy link
Author

min and max can be optional, but value shouldn't be - we prefer users to provide a defined value rather than relying on a default 0

Could you update the PR accordingly so I can merge it @stabldev ?

It has default values for min, max and value.
So it shows ts warn when nothing is provided, but works,
in most of the case, only the value gets updated.

is this the intended behaviour or am i missing something?

max = 100,
min = 0,
value = 0,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants