fix: typing animation displaying emojis #685
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
The root cause is in the [TypingAnimation.tsx] component, specifically within the useEffect hook responsible for the typing logic. It iterates through the string using children.length and builds the displayed text using children.substring(0, i + 1). These JavaScript string methods operate on UTF-16 code units, not grapheme clusters. Emojis often consist of multiple code units, causing them to be split incorrectly.
Fix:
Split the input string into an array of grapheme clusters using const graphemes = Array.from(children);.
Iterate based on graphemes.length.
Reconstruct the displayed text using setDisplayedText(graphemes.slice(0, i + 1).join(""));.
This ensures that each "visible character," including emojis, is treated as a single unit.
typing_animation_bug.mp4
typing_animation_fix.mp4