Add meson build system for C++ #41
Conversation
| 'UnitVector3d.cc', | ||
| 'utils.cc', | ||
| 'Vector3d.cc'] | ||
| sphgeom = static_library( |
There was a problem hiding this comment.
Why a static library, particularly? If you just use library() it becomes the choice of the builder (via -Ddefault_library=static, but it also accepts =both to build both at the same time).
The cmake build uses shared, not static, though cmake doesn't really have a good way to choose between the two.
There was a problem hiding this comment.
We can do just library(). I would assume that I didn't know I had the option at that time.
|
|
||
| subdir('src') | ||
|
|
||
| pkg_mod = import('pkgconfig') |
There was a problem hiding this comment.
In addition to creating a pkg-config file, you may also want to create a declare_dependency() that adds the incdir and the sphgeom library, as an interface, which then allows using this meson.build as a Meson subproject with automatic dependency fallback.
There was a problem hiding this comment.
how would I do declare_dependency()? I guess I'm not following.
| incdir = include_directories('../include/') | ||
|
|
||
| install_headers( | ||
| '../include/lsst/sphgeom/Angle.h', | ||
| '../include/lsst/sphgeom/AngleInterval.h', |
There was a problem hiding this comment.
Personally, I would define this in subdir('include') so you don't need all these ../ everywhere. :)
There was a problem hiding this comment.
I didn't know that was possible. No objections from me.
bonimy
force-pushed
the
meson
branch
3 times, most recently
from
2c4f45a to
8a2e1e1
Compare
|
Just bumping to say that I've been in the process of moving states, but I'll hopefully finish this PR soon once things settle down. |
timj
force-pushed
the
meson
branch
2 times, most recently
from
a19f8bb to
b552bcd
Compare
|
I rebased this PR just in case there is still interest in it. |
I'm writing a project using meson as the build system as sphgeom happens to be a dependence. There were a few issues trying to build with cmake and I found it easier to just add meson support.
|
Sorry for never getting back to this. I ended up switching career paths. If someone wants to take over this branch to merge it, please do. I haven't worked with meson for so long that I don't think I'd remember how to finish this branch out. |
I'm writing a project using meson as the build system as sphgeom
happens to be a dependence. There were a few issues trying to build with
cmake and I found it easier to just add meson support.