Skip to content

DM-45834: Fix C++17 deprecations and C++20 compilation #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mwittgen
Copy link
Contributor

No description provided.

@mwittgen mwittgen requested a review from TallJimbo August 21, 2024 14:21
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final result looks good, but it seems you've got a pair of commits that cancel out. Best to drop them, unless they're designed such that one could be reverted in the future.

@mwittgen mwittgen merged commit 4005a62 into main Aug 23, 2024
2 checks passed
@mwittgen mwittgen deleted the tickets/DM-45834 branch August 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants