Skip to content

DM-45486: Remove lsst::utils fallback #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/lsst/cpputils/Backtrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ class Backtrace final {
};

} // namespace cpputils
namespace utils = cpputils;
} // namespace lsst

#endif
1 change: 0 additions & 1 deletion include/lsst/cpputils/Cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@ Cache<Key, Value, KeyHash, KeyPred>::~Cache() {
#endif

}
namespace utils = cpputils;
} // namespace lsst::cpputils


Expand Down
1 change: 0 additions & 1 deletion include/lsst/cpputils/CacheFwd.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ template <typename Key, typename Value, typename KeyHash=std::hash<Key>,
class Cache;

}
namespace utils = cpputils;
} // namespace lsst::cpputils

#endif // ifndef LSST_CPPUTILS_CACHE_FWD_H
1 change: 0 additions & 1 deletion include/lsst/cpputils/Demangle.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@ namespace cpputils {
std::string demangleType(std::string const _typeName);

}
namespace utils = cpputils;
} // namespace lsst::cpputils
#endif
1 change: 0 additions & 1 deletion include/lsst/cpputils/Magnitude.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ double nanojanskyToABMagnitude(double flux);
double ABMagnitudeToNanojansky(double magnitude);

} // namespace cpputils
namespace utils = cpputils;
} // namespace lsst

#endif // LSST_CPPUTILS_MAGNITUDE_H
1 change: 0 additions & 1 deletion include/lsst/cpputils/hashCombine.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ std::size_t hashIterable(std::size_t seed, InputIterator begin, InputIterator en
}

}
namespace utils = cpputils;
} // namespace lsst::cpputils

#endif
1 change: 0 additions & 1 deletion include/lsst/cpputils/packaging.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ namespace cpputils {
std::string getPackageDir(std::string const& packageName);

}
namespace utils = cpputils;
} // namespace lsst::cpputils

#endif
1 change: 0 additions & 1 deletion include/lsst/cpputils/python.h
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,6 @@ class LSST_PRIVATE WrapperCollection final {


}}
namespace utils = cpputils;
} // namespace lsst::cpputils::python

#endif
1 change: 0 additions & 1 deletion include/lsst/cpputils/python/Cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ void declareCache(py::module & mod, std::string const& name) {
}

}}
namespace utils = cpputils;
} // namespace lsst::cpputils::python

#endif // ifndef LSST_CPPUTILS_PYTHON_CACHE_H
1 change: 0 additions & 1 deletion include/lsst/cpputils/python/PySharedPtr.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ class PySharedPtr final {

} // namespace python
} // namespace cpputils
namespace utils = cpputils;
} // namespace lsst

// Macro must be called in the global namespace
Expand Down
1 change: 0 additions & 1 deletion include/lsst/cpputils/python/TemplateInvoker.h
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ class TemplateInvoker {
};

}}
namespace utils = cpputils;
} // namespace lsst::cpputils::python

#endif
1 change: 0 additions & 1 deletion include/lsst/cpputils/tests.h
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ void assertHashesEqual(T obj1, T obj2) {
}

} // namespace cpputils
namespace utils = cpputils;
} // namespace lsst

#endif
1 change: 0 additions & 1 deletion include/lsst/utils/Backtrace.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/Cache.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/CacheFwd.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/Demangle.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/Magnitude.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/hashCombine.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/packaging.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/python.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/python/Cache.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/python/PySharedPtr.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/python/TemplateInvoker.h

This file was deleted.

1 change: 0 additions & 1 deletion include/lsst/utils/tests.h

This file was deleted.

6 changes: 0 additions & 6 deletions tests/test_packaging.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@ BOOST_AUTO_TEST_CASE(GetPackage) {
BOOST_CHECK(std::filesystem::is_regular_file(cpputilsPath / "tests" / "test_packaging.cc"));
BOOST_CHECK_THROW(getPackageDir("nameOfNonexistendPackage2234q?#!"),
lsst::pex::exceptions::NotFoundError);

// Again with the lsst::utils namespace
std::filesystem::path utilsPath{lsst::utils::getPackageDir("cpputils")};
BOOST_CHECK(std::filesystem::is_regular_file(utilsPath / "tests" / "test_packaging.cc"));
BOOST_CHECK_THROW(lsst::utils::getPackageDir("nameOfNonexistendPackage2234q?#!"),
lsst::pex::exceptions::NotFoundError);
}

BOOST_AUTO_TEST_SUITE_END()
Loading