[TTI] Treat *l (long double) and *f128 (_Float128) libcalls the same
#148311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tgross35
force-pushed
the
transform-fp128
branch
from
7e95baa to
23b5952
Compare
As noted in the preexisting FIXME above this hunk, the logic in this function is not always accurate. However, the logic for `long double` and `_Float128` should be approximately the same for these functions (almost everything requiring a libcall), so it makes sense to treat them the same. This is meant to reduce churn in cases where `*l` and `*f128` lowerings call to the same symbol so can be used interchangeably.
tgross35
force-pushed
the
transform-fp128
branch
from
23b5952 to
a2791cb
Compare
llvmbot
added
the
llvm:analysis
|
@llvm/pr-subscribers-llvm-analysis Author: Trevor Gross (tgross35) ChangesAs noted in the preexisting FIXME above this hunk, the logic in this function is not always accurate. However, the logic for This is meant to reduce churn in cases where Full diff: https://github.com/llvm/llvm-project/pull/148311.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Analysis/TargetTransformInfoImpl.h b/llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
index ddc8a5eaffa94..bae499d99b092 100644
--- a/llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
+++ b/llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
@@ -189,27 +189,28 @@ class TargetTransformInfoImplBase {
// These will all likely lower to a single selection DAG node.
// clang-format off
- if (Name == "copysign" || Name == "copysignf" || Name == "copysignl" ||
- Name == "fabs" || Name == "fabsf" || Name == "fabsl" ||
- Name == "fmin" || Name == "fminf" || Name == "fminl" ||
- Name == "fmax" || Name == "fmaxf" || Name == "fmaxl" ||
- Name == "sin" || Name == "sinf" || Name == "sinl" ||
- Name == "cos" || Name == "cosf" || Name == "cosl" ||
- Name == "tan" || Name == "tanf" || Name == "tanl" ||
- Name == "asin" || Name == "asinf" || Name == "asinl" ||
- Name == "acos" || Name == "acosf" || Name == "acosl" ||
- Name == "atan" || Name == "atanf" || Name == "atanl" ||
- Name == "atan2" || Name == "atan2f" || Name == "atan2l"||
- Name == "sinh" || Name == "sinhf" || Name == "sinhl" ||
- Name == "cosh" || Name == "coshf" || Name == "coshl" ||
- Name == "tanh" || Name == "tanhf" || Name == "tanhl" ||
- Name == "sqrt" || Name == "sqrtf" || Name == "sqrtl" ||
- Name == "exp10" || Name == "exp10l" || Name == "exp10f")
+ if (Name == "copysign" || Name == "copysignf" || Name == "copysignl" || Name == "copysignl128" ||
+ Name == "fabs" || Name == "fabsf" || Name == "fabsl" || Name == "fabsl128" ||
+ Name == "fmin" || Name == "fminf" || Name == "fminl" || Name == "fminl128" ||
+ Name == "fmax" || Name == "fmaxf" || Name == "fmaxl" || Name == "fmaxl128" ||
+ Name == "sin" || Name == "sinf" || Name == "sinl" || Name == "sinl128" ||
+ Name == "cos" || Name == "cosf" || Name == "cosl" || Name == "cosl128" ||
+ Name == "tan" || Name == "tanf" || Name == "tanl" || Name == "tanl128" ||
+ Name == "asin" || Name == "asinf" || Name == "asinl" || Name == "asinl128" ||
+ Name == "acos" || Name == "acosf" || Name == "acosl" || Name == "acosl128" ||
+ Name == "atan" || Name == "atanf" || Name == "atanl" || Name == "atanl128" ||
+ Name == "atan2" || Name == "atan2f" || Name == "atan2l"|| Name == "atan2128l"||
+ Name == "sinh" || Name == "sinhf" || Name == "sinhl" || Name == "sinhl128" ||
+ Name == "cosh" || Name == "coshf" || Name == "coshl" || Name == "coshl128" ||
+ Name == "tanh" || Name == "tanhf" || Name == "tanhl" || Name == "tanhl128" ||
+ Name == "sqrt" || Name == "sqrtf" || Name == "sqrtl" || Name == "sqrtl128" ||
+ Name == "exp10" || Name == "exp10f" || Name == "exp10l"|| Name == "exp10f128")
return false;
// clang-format on
// These are all likely to be optimized into something smaller.
- if (Name == "pow" || Name == "powf" || Name == "powl" || Name == "exp2" ||
- Name == "exp2l" || Name == "exp2f" || Name == "floor" ||
+ if (Name == "pow" || Name == "powf" || Name == "powl" ||
+ Name == "powf128" || Name == "exp2" || Name == "exp2f" ||
+ Name == "exp2l" || Name == "powf128" || Name == "floor" ||
Name == "floorf" || Name == "ceil" || Name == "round" ||
Name == "ffs" || Name == "ffsl" || Name == "abs" || Name == "labs" ||
Name == "llabs")
|
I assume there is a test for the current |
nikic
reviewed
Jul 12, 2025
Comment the code out, run the tests, and see what fails :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the preexisting FIXME above this hunk, the logic in this function is not always accurate. However, the logic for
long doubleand_Float128should be approximately the same for these functions (almost everything requiring a libcall), so it makes sense to treat them the same.This is meant to reduce churn in cases where
*land*f128lowerings call to the same symbol so can be used interchangeably.