Skip to content

[libcxx] Enable installing new runner binary on existing container #148073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: users/boomanaiden154/main.libcxx-enable-installing-new-runner-binary-on-existing-container
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/libcxx-build-containers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ jobs:

- name: Build the Linux builder image
working-directory: libcxx/utils/ci
run: docker compose build actions-builder
run: |
docker compose build builder-base
docker compose build actions-builder
env:
TAG: ${{ github.sha }}

Expand All @@ -57,6 +59,7 @@ jobs:
if: github.event_name == 'push'
working-directory: libcxx/utils/ci
run: |
docker compose push builder-base
docker compose push actions-builder
env:
TAG: ${{ github.sha }}
Expand Down
3 changes: 2 additions & 1 deletion libcxx/utils/ci/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
# If you're only looking to run the Docker image locally for debugging a
# build bot, see the `run-buildbot-container` script located in this directory.

ARG ACTIONS_BASE_IMAGE

# HACK: We set the base image in the docker-compose file depending on the final target (buildkite vs github actions).
# This means we have a much slower container build, but we can use the same Dockerfile for both targets.
Expand Down Expand Up @@ -310,7 +311,7 @@ CMD /opt/android/container-setup.sh && buildkite-agent start
#
# IMAGE: ghcr.io/libcxx/actions-builder.
#
FROM builder-base AS actions-builder
FROM $ACTIONS_BASE_IMAGE AS actions-builder

ARG GITHUB_RUNNER_VERSION

Expand Down
11 changes: 11 additions & 0 deletions libcxx/utils/ci/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,16 @@ x-versions: &compiler_versions
LLVM_HEAD_VERSION: 21

services:
builder-base:
image: ghcr.io/llvm/libcxx-linux-builder-base:${TAG}
build:
context: .
dockerfile: Dockerfile
target: builder-base
args:
BASE_IMAGE: ubuntu:jammy
<<: *compiler_versions

actions-builder:
image: ghcr.io/llvm/libcxx-linux-builder:${TAG}
build:
Expand All @@ -11,6 +21,7 @@ services:
target: actions-builder
args:
BASE_IMAGE: ubuntu:jammy
ACTIONS_BASE_IMAGE: builder-base
GITHUB_RUNNER_VERSION: "2.326.0"
<<: *compiler_versions

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.