-
Notifications
You must be signed in to change notification settings - Fork 29
Bump SQLAlchemy==1.3.24 to support lnt on Windows #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
LNT crashes on windows on startup with following error in SQLAlchemy: AttributeError: module 'time' has no attribute 'clock' This patch upgrades SQLAlchemy to 1.3.24 which resolves above error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a big jump to solve a seemingly simple error.
Can you:
- Include the traceback in the PR description for folks stumbling on this later
- Cite some change in SQLAlchemy that justifies the version and what got fixed?
I have updated the PR description with more details. Let me know if it explains the choice of upgrading to 1.3.24. |
They don't say what their versioning rules are but considering that https://docs.sqlalchemy.org/en/20/changelog/migration_20.html exists, assuming that breaking changes would mean new major version seems safe. |
That time.clock, https://docs.python.org/3.5/library/time.html#time.clock
Removed in 3.8: https://docs.python.org/3/whatsnew/3.8.html#api-and-feature-removals So it's not so much Windows as it is Python >= 3.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, put whatever information in the PR message that makes sense to you as justification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have tested it with python 3.12.3
LNT crashes on windows on startup with following error in SQLAlchemy:
The issue was fixed in SQLAlchemy by sqlalchemy/sqlalchemy@003333f
This patch upgrades SQLAlchemy to 1.3.24 which resolves above error. Version 1.3.24 seemed like a reasonable upgrade containing the required fix as it does not contain any backward incompatible changes in some of the higher version of SQLAlchemy.