Fix handling of links in atom feeds #142
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code iterated over entry links like this:
for link in self.__atom_link or []:
link = xml_elem('link', entry, href=link['href'])
The first line in the loop overwrites the `link` variable, rendering the
rest of the loop a no-op. This commit corrects the situation by creating a
new variable rather than overwriting the loop variable.
|
Oh, never mind. This is a dupe of #139. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code iterated over entry links like this:
The first line in the loop overwrites the
linkvariable, rendering therest of the loop a no-op. This commit corrects the situation by creating a
new variable rather than overwriting the loop variable.