Michael elf parsing - LSDA parsing #17

Mchan2003 · 2025-05-01T19:05:30Z

Added ElfParser class
Features
- able to parse out the headers
- open and close ELF files
- implemented LSDA parsing

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

kammce · 2025-05-01T21:10:38Z

CMakeLists.txt

 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 add_custom_target(copy_compile_commands ALL
    COMMAND ${CMAKE_COMMAND} -E copy_if_different
    ${CMAKE_BINARY_DIR}/compile_commands.json
    ${CMAKE_SOURCE_DIR}/compile_commands.json
    DEPENDS ${CMAKE_BINARY_DIR}/compile_commands.json)

+# Find package dependancies
+list(APPEND CMAKE_PREFIX_PATH "${CMAKE_SOURCE_DIR}/build/Debug/generators") #TODO: Remove due to this being a temporary patch for libraries to work


Try and keep code at 80 columns. Makes it easier to look at in most editors.

kammce · 2025-05-01T21:12:31Z

include/elf_parser.hpp

+#pragma once
+#include <bitset>
+#include <err.h>
+#include <fcntl.h>
+#include <gelf.h>
+#include <libelf.h>
+#include <print>
+#include <stdlib.h>
+#include <string>
+#include <sysexits.h>
+#include <unistd.h>


Suggested change

#pragma once

#include <bitset>

#include <err.h>

#include <fcntl.h>

#include <gelf.h>

#include <libelf.h>

#include <print>

#include <stdlib.h>

#include <string>

#include <sysexits.h>

#include <unistd.h>

#pragma once

#include <err.h>

#include <fcntl.h>

#include <stdlib.h>

#include <sysexits.h>

#include <unistd.h>

#include <gelf.h>

#include <libelf.h>

#include <bitset>

#include <string>

#include <print>

Lets follow the libhal style guide for headers: https://libhal.github.io/4.1/contributor_guide/style/#s143-include-order

kammce · 2025-05-01T21:14:36Z

include/elf_parser.hpp

+    ElfParser(char** t_file_ptr)
+      : m_file(t_file_ptr){};


Suggested change

ElfParser(char** t_file_ptr)

: m_file(t_file_ptr){};

ElfParser(char** p_file_ptr)

: m_file(p_file_ptr){};

Input parameters should have prefix p_

kammce · 2025-05-01T21:16:22Z

include/elf_parser.hpp

+    int m_fd, m_fbin;
+    size_t m_n, m_shstrndx;
+
+    char** m_file;


I'd recommend replacing this with std::string so this object owns the string data.

kammce · 2025-05-01T21:17:12Z

include/elf_parser.hpp

+    int m_elf_class{ 0 };
+    int m_fd, m_fbin;
+    size_t m_n, m_shstrndx;
+
+    char** m_file;
+
+    char* m_name;
+    Elf_Scn* m_scn;
+    Elf_Data* m_data;
+
+    Elf* m_e;
+    GElf_Ehdr m_ehdr;
+    GElf_Phdr m_phdr;
+    GElf_Shdr m_shdr;
+    //Gelf_Sym m_sym;


I cannot, from visual inspection understand what of these are and why they need to be in the fields of the class.

kammce · 2025-05-01T21:32:24Z

include/elf_parser.hpp

+    }
+}
+
+void ElfParser::getSection(std::string section)


I don't think the API name makes sense for what it does. Its more like it dumps the section to a bin file.

kammce · 2025-05-01T21:32:55Z

include/elf_parser.hpp

+void ElfParser::closeElf()
+{
+    close(m_fd);
+    std::println("ELF file closed");
+}


This should be in the destructor.

kammce · 2025-05-01T21:33:08Z

src/main.cpp

+#include "../include/elf_parser.hpp"
+#include <bitset>
 #include <print>
+#include <string>


Fix the order

kammce · 2025-05-01T21:33:19Z

src/main.cpp

+    std::string lsda = ".gcc_except_table";
+    std::string symtab = ".symtab";


Is it possible to not use std::string here?

std::string_view would work here instead.

kammce · 2025-05-01T21:34:31Z

src/main.cpp

    return 0;
+    ;


Add newline to file for all files.

kammce · 2025-05-01T21:35:02Z

Also make everything snake_case

…, move loading of the headers to the constructor, reformat to fit libhal formatting standard

Mchan2003 linked an issue May 1, 2025 that may be closed by this pull request

ELF Parsing #1

Open

Mchan2003 requested a review from kammce May 1, 2025 20:20

add elf_parser .hpp with function to open the elf file and read out t…

e9790c5

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

Mchan2003 force-pushed the Michael-ELF_parsing branch from 3f85911 to e9790c5 Compare May 1, 2025 21:09

kammce requested changes May 1, 2025

View reviewed changes

Reworked the parser to store the elf file headers in maps and vectors…

6714ca4

…, move loading of the headers to the constructor, reformat to fit libhal formatting standard

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Michael elf parsing - LSDA parsing #17

Michael elf parsing - LSDA parsing #17

Uh oh!

Mchan2003 commented May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce May 1, 2025

Uh oh!

kammce commented May 1, 2025

Uh oh!

Uh oh!

		std::string lsda = ".gcc_except_table";
		std::string symtab = ".symtab";

Michael elf parsing - LSDA parsing #17

Are you sure you want to change the base?

Michael elf parsing - LSDA parsing #17

Uh oh!

Conversation

Mchan2003 commented May 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kammce commented May 1, 2025

Uh oh!

Uh oh!