[WIP] Remove conda yaml #1135
[WIP] Remove conda yaml #1135
Conversation
| string python_version = 1; // 3.8, 3.9, ..., without patch | ||
| /* optional */ string pypi_index_url = 2; // Url of pypi index. If not set, using https://pypi.org/simple | ||
| repeated PythonPackage requirements = 3; // Requirements to install | ||
| repeated string local_modules_urls = 4; // Urls in storage to get local modules from |
There was a problem hiding this comment.
Возможно, с целью написания дебаг-логов на сервере, локальный модуль представлять не только как URL, но как пару (URL, original_path_on_client). Но не знаю, насколько это необходимо. В целом есть ощущение, что под локальный модуль хочется зарезервировать целый message, чтобы в случае чего это было расширяемо. Например, сейчас у нас по урлам лежат архивы, но это может поменяться, и нужна будет какая-то мета про то, что лежит в урле.
There was a problem hiding this comment.
also we could add some archive codec information here
There was a problem hiding this comment.
Ok, I will add message LocalModule here
| string name = 1; | ||
| string yaml = 2; | ||
| repeated LocalModule local_modules = 3; | ||
| string python_version = 1; // 3.8, 3.9, ..., without patch |
There was a problem hiding this comment.
Why are you repeating 1:1 PythonEnvSpec here?
There was a problem hiding this comment.
Because this is private api, and PythonEnvSpec is in public.
| string name = 1; // Name of module | ||
| string url = 2; // Url in storage to get module from | ||
| string python_version = 1; // 3.8, 3.9, ..., without patch | ||
| /* optional */ string pypi_index_url = 2; // Url of pypi index. If not set, using https://pypi.org/simple |
There was a problem hiding this comment.
Maybe you should add extra_index_url (repeated) and find_links (repeated) for future?
look at pip install --help
There was a problem hiding this comment.
May be we just should pass requirements.txt file contents, it supports all features and options of pip – https://pip.pypa.io/en/stable/reference/requirements-file-format/, including extra_index_url and others. Then we can just install packages with pip, without conda.
|
|
||
| message PythonPackage { | ||
| string name = 1; | ||
| string version = 2; |
There was a problem hiding this comment.
we should also support things like package>=1.0,<2.0,!=1.5
and may be URL requirement (like Git)
so may be all requirements will be list of string, each string is requirement expression, like line in requirements.txt file
this could be non-secure though, we'll have to sanitize such expressions
No description provided.