Skip to content

Do not recreate container when scale resource #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

supermeng
Copy link
Member

Fix issue #51

@ghost ghost assigned supermeng Mar 2, 2018
@ghost ghost added the needs review label Mar 2, 2018
@supermeng supermeng force-pushed the master branch 2 times, most recently from 00c72ee to e40435e Compare March 2, 2018 10:00
@codecov
Copy link

codecov bot commented Mar 5, 2018

Codecov Report

Merging #52 into master will decrease coverage by 0.89%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #52     +/-   ##
=========================================
- Coverage   49.44%   48.54%   -0.9%     
=========================================
  Files          20       20             
  Lines        3578     3646     +68     
=========================================
+ Hits         1769     1770      +1     
- Misses       1627     1691     +64     
- Partials      182      185      +3
Impacted Files Coverage Δ
engine/specs.go 53.19% <ø> (-1.84%) ⬇️
engine/config.go 31.57% <ø> (ø) ⬆️
engine/runtimes.go 31.25% <ø> (-1.17%) ⬇️
engine/podgroup.go 48.08% <44.44%> (-1.2%) ⬇️
engine/podgroup_ops.go 42.22% <83.33%> (-7.27%) ⬇️
engine/pod.go 61.69% <85%> (+1.2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0b190...0dc379f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant