Skip to content

Make it possible to provide a custom issuer for the certificate in the Helm chart #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Make it possible to provide a custom issuer for the certificate in the Helm chart #4256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion helm/aws-load-balancer-controller/templates/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ spec:
- {{ template "aws-load-balancer-controller.webhookService" . }}.{{ .Release.Namespace }}.svc.{{ .Values.cluster.dnsDomain }}
issuerRef:
kind: Issuer
name: {{ template "aws-load-balancer-controller.namePrefix" . }}-selfsigned-issuer
name: {{ default (printf "%s-selfsigned-issuer" (include "aws-load-balancer-controller.namePrefix" .)) .Values.certManager.existingIssuerName }}
secretName: {{ template "aws-load-balancer-controller.webhookCertSecret" . }}
{{- with .Values.certManager -}}
{{ if .duration }}
Expand All @@ -246,6 +246,7 @@ spec:
{{- end }}
{{- end }}
---
{{- if not $.Values.certManager.existingIssuerName }}
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
Expand All @@ -256,3 +257,4 @@ metadata:
spec:
selfSigned: {}
{{- end }}
{{- end }}
3 changes: 3 additions & 0 deletions helm/aws-load-balancer-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ enableCertManager: false
certManager:
duration:
renewBefore:
# name of the existing issuer to use for certificate requests
# when set, the controller will not create a self-signed issuer
existingIssuerName:

# The name of the Kubernetes cluster. A non-empty value is required
clusterName:
Expand Down