-
Notifications
You must be signed in to change notification settings - Fork 66
Update rust-config to 0.15 #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for the contribution! For dependencies updates, we usually rely on dependabot PRs. We also follow kind of a selfish unwritten rule that we do not merge bumps to dependencies for versions that are not available on Fedora. Fedora has a strict rule that only packaged crates can be used to build other components. If we update dependencies upstream (i.e. here in this repository) to versions that are not available in Fedora, later we have difficulties building our package updates there. Unfortunately we cannot merge this at the moment. I hope you understand. |
This PR is explicitly to unlock the packaging of |
I see... I believe we have a classic chicken-egg problem here. I will reopen the PR, please rebase it on top of current master. In future, please be explicit about the intention behind an open PR 😄 |
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
bf902bb
to
f55e134
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Thanks for the rebase, and sorry I didn't get back to it, it fell off my radar |
@LecrisUT I think the change itself is ok, the test that is erroring is probably due to some infra issue in the CI pipeline. I can approve and merge this if you promise the new version of the |
I am packaging the dependency for rust-config. How about I ping you when it is ready to be merged (should be in 2 weeks) |
That would be great, thank you! |
/packit retest-failed |
Couldn't test locally, hopefully the CI can handle it