Skip to content

Update rust-config to 0.15 #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LecrisUT
Copy link

@LecrisUT LecrisUT commented May 1, 2025

Couldn't test locally, hopefully the CI can handle it

@LecrisUT LecrisUT force-pushed the deps/rust-config branch from f0d983f to bf902bb Compare May 1, 2025 14:18
@ansasaki
Copy link
Contributor

ansasaki commented May 9, 2025

Thank you for the contribution!

For dependencies updates, we usually rely on dependabot PRs. We also follow kind of a selfish unwritten rule that we do not merge bumps to dependencies for versions that are not available on Fedora.

Fedora has a strict rule that only packaged crates can be used to build other components. If we update dependencies upstream (i.e. here in this repository) to versions that are not available in Fedora, later we have difficulties building our package updates there.

Unfortunately we cannot merge this at the moment. I hope you understand.

@ansasaki ansasaki closed this May 9, 2025
@LecrisUT
Copy link
Author

LecrisUT commented May 9, 2025

This PR is explicitly to unlock the packaging of rust-config 0.15. See https://src.fedoraproject.org/rpms/rust-config/pull-request/4

@ansasaki
Copy link
Contributor

This PR is explicitly to unlock the packaging of rust-config 0.15. See https://src.fedoraproject.org/rpms/rust-config/pull-request/4

I see... I believe we have a classic chicken-egg problem here. I will reopen the PR, please rebase it on top of current master.

In future, please be explicit about the intention behind an open PR 😄

@ansasaki ansasaki reopened this May 12, 2025
@ansasaki ansasaki mentioned this pull request May 28, 2025
30 tasks
LecrisUT and others added 2 commits June 11, 2025 14:45
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.07%. Comparing base (4f0360d) to head (f55e134).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 60.07% <ø> (-2.05%) ⬇️
upstream-unit-tests 60.07% <ø> (-2.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LecrisUT
Copy link
Author

Thanks for the rebase, and sorry I didn't get back to it, it fell off my radar

@ansasaki
Copy link
Contributor

@LecrisUT I think the change itself is ok, the test that is erroring is probably due to some infra issue in the CI pipeline.

I can approve and merge this if you promise the new version of the config crate will be available in Fedora soon :)

@LecrisUT
Copy link
Author

I am packaging the dependency for rust-config. How about I ping you when it is ready to be merged (should be in 2 weeks)

@ansasaki
Copy link
Contributor

I am packaging the dependency for rust-config. How about I ping you when it is ready to be merged (should be in 2 weeks)

That would be great, thank you!

@sarroutbi
Copy link
Contributor

/packit retest-failed

@ansasaki ansasaki mentioned this pull request Jun 19, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants