config: rework all coverage-enabled jobs #1244
Draft
+280
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created as draft for now as it requires more testing |
a-wai
force-pushed
the
rework-coverage-jobs
branch
2 times, most recently
from
8ea7e4d to
d3c0454
Compare
Those jobs were useful as a first step towards enabling code coverage, however reflecting more on this use-case, we came to the conclusion that our only target so far is the ChromeOS kernel. We should therefore get rid of the current jobs and add more relevant ones as a follow-up. Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
In order to provide meaningful code coverage results for the ChromeOS kernel tree, we should create new builds with all the relevant fragments so we can run various tests on those. Those builds are created for each SoC vendor and will only be triggered for the `chromiumos` tree. They include the `coverage` fragment of course, but also `kselftest` and `crypto` allowing both `kselftest` and LTP jobs (including `ltp-crypto`) to be triggered by those builds. Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
This requires changing the LTP jobs' definition to allow running on kernels for which the `kselftest` fragment has been enabled. AFAIK this restriction has been ported from the legacy KernelCI config and was likely only needed back then to avoid scheduling too many instances of LTP jobs. It is therefore unnecessary on Maestro which allows for more fine-grained scheduling. Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
a-wai
force-pushed
the
rework-coverage-jobs
branch
from
d3c0454 to
19c34c3
Compare
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our only planned user for code coverage analysis is the ChromeOS kernel team, so this PR fully reworks the coverage-enabled builds and test jobs.
To sum things up, the current, generic x86 kernel build is replaced by 4 distinct builds:
Those builds use the following config fragments on top of the usual ones:
coveragefor enabling GCOV support in the kernelkselftestso we can run the corresponding tests on those kernelscryptoso those kernels can also execute theltp-cryptojobAll LTP & kselftest jobs currently executed on the ChromeOS kernel are now also scheduled for those new builds, replacing the previous LTP scheduler entries (those were using the generic x86 build which is phased out in this PR).