Skip to content

Fix: remove non-existent reference in 'pipeline.yaml' for local deployment, build missing pipeline images #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tollsimy
Copy link
Contributor

@tollsimy tollsimy commented Apr 3, 2025

This PR fixes the following issue when starting a local deployment with a 'kernelci-pipeline-lava-callback' service with the default pipeline.yaml.

Steps to reproduce:

cd localinstall
python kci-deploy.py
cd kernelci/kernelci-pipeline
docker-compose -f docker-compose-lava.yaml up

Issue:

Traceback (most recent call last):
  File "/home/kernelci/pipeline/lava_callback.py", line 34, in <module>
    CONFIGS = kernelci.config.load(
              ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 191, in load
    data = load_yaml(config_paths)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 149, in load_yaml
    data = load_single_yaml(path)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 86, in load_single_yaml
    for _, data in iterate_yaml_files(config_path):
  File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 30, in iterate_yaml_files
    data = yaml.safe_load(yaml_file)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/__init__.py", line 125, in safe_load
    return load(stream, SafeLoader)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/__init__.py", line 81, in load
    return loader.get_single_data()
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/constructor.py", line 49, in get_single_data
    node = self.get_single_node()
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 68, in compose_node
    raise ComposerError(None, None, "found undefined alias %r"
yaml.composer.ComposerError: found undefined alias 'build-variants'
  in "config/pipeline.yaml", line 189, column 15

and add the build of missing pipeline images (related to kernelci/kernelci-pipeline#1102).

…yment

Signed-off-by: Simone Tollardo <tollsimy.dev@protonmail.com>
Signed-off-by: Simone Tollardo <tollsimy.dev@protonmail.com>
@tollsimy tollsimy changed the title Fix: remove non-existent reference in 'pipeline.yaml' for local deployment Fix: remove non-existent reference in 'pipeline.yaml' for local deployment, build missing pipeline images Apr 4, 2025
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuclearcat nuclearcat merged commit 29f4417 into kernelci:main Apr 7, 2025
1 check passed
@tollsimy tollsimy deleted the fix/deploy-local branch April 7, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants