kernelci: api: helper: don't crash when adding artifacts to node #2916
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-wai
force-pushed
the
helper-fix-null-artifacts
branch
from
60d099f to
ed711e2
Compare
a-wai
force-pushed
the
helper-fix-null-artifacts
branch
2 times, most recently
from
413bbcc to
ece4877
Compare
Nodes are created with `'artifacts': null`, meaning calling `update()` could lead to an uncaught exception, and therefore a crash. Avoid this situation by ensuring this field is a dict before calling `update()`. Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
a-wai
force-pushed
the
helper-fix-null-artifacts
branch
from
ece4877 to
d6b3563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes are created with
'artifacts': null, meaning callingupdate()could lead to an uncaught exception, and therefore a crash. Avoid this situation by ensuring this field is a dict before callingupdate().