fix: reset selection mode after deletion #4661
Conversation
There was a problem hiding this comment.
Nice, thanks for the contribution. I pushed two fixups; one is mentioned below, the other one fixes a failing test (6f9f305).
How much of an audit of the code did you do to find other cases? Or did you only fix the two cases mentioned in #4612? I think deleting branches in the remote branches panel (the one that you get when pressing enter on a remote) is also still broken, not sure if there are any others.
| @@ -557,6 +557,7 @@ func (self *BranchesController) delete(branches []*models.Branch) error { | |||
| Label: lo.Ternary(len(branches) > 1, self.c.Tr.DeleteLocalBranches, self.c.Tr.DeleteLocalBranch), | |||
| Key: 'c', | |||
| OnPress: func() error { | |||
| self.context().SetSelection(startIdx) | |||
There was a problem hiding this comment.
I'd prefer to do this only after deleting succeeded; if deleting the branches fails for whatever reason, the selection should stay unchanged. I pushed a fixup to change this (362a8f9).
|
@stefanhaller Thanks for fixups! I think I might have missed some more cases. I checked the panels with local commits, local branches and stashes. I'll try to check other panels later |
Fixes selection state persistence after deletion by resetting selection mode.
Resolves #4612
go generate ./...)