fix MC-219981 #434
Draft
fix MC-219981 #434
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you link the NeoForge PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.mojang.com/browse/MC/issues/MC-219981: If zombies spawned with max health over 20 (leader zombie bonus), they will have 20 health instead of their max health
This fix is slightly more complicated than I would have done it, as I want to follow how the open NeoForge PR does it. Instead of simply setting the zombie health to max health, it checks for damage taken and subtracts that. I'm not sure under what conditions they would spawn with less health, but in another mod's GitHub issue discussion there were zombies at 19 health, so I guess this works. I would have scaled with max HP instead of just subtracting damage, but I want to keep this in line with what NeoForge does.
Keeping in draft until the NeoForge PR comes to a consensus and is merged.