Fix several sound related bugs #425
Merged
+86
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i am now unsure if we would want MC-248223 to be fixed. realistically in the default pack you cant tell, and pack creators can fix this themselves. if any custom server pack uses these sounds in wildly different ways, it could be weird. i'll remove it from this PR, let me know if you would still be interested in it though |
isXander
requested changes
Jul 20, 2025
forgot to remove it when i removed the fix for MC-248223, removed it now 👍 |
isXander
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MC-139041: https://bugs.mojang.com/browse/MC/issues/MC-139041
MC-202637: https://bugs.mojang.com/browse/MC/issues/MC-202637
MC-227337: https://bugs.mojang.com/browse/MC/issues/MC-227337
MC-245394: https://bugs.mojang.com/browse/MC/issues/MC-245394
MC-248223: https://bugs.mojang.com/browse/MC/issues/MC-248223